Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wsg_50_description] Move Drake files and punyo meshes into here #53

Merged

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Apr 1, 2024

The schunk_wsg_50_hydro_bubble is copied from Drake as of e7aa6fcd.

Some new README content is based off Drake's related README.

Twin PR: RobotLocomotion/drake#21231


This change is Reviewable

@jwnimmer-tri
Copy link
Contributor Author

+@DamrongGuoy for feature review, please.

Copy link
Contributor

@DamrongGuoy DamrongGuoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

CC: @joemasterjohn

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @jwnimmer-tri)

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@rpoyner-tri for platform review per schedule (tomorrow), please.

Reviewable status: all discussions resolved, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @rpoyner-tri)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't tomorrow @ggould-tri ?

Reviewable status: all discussions resolved, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Contributor Author

Yup, sorry!

Copy link

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [ggould-tri] (waiting on @jwnimmer-tri)

The schunk_wsg_50_hydro_bubble is copied from Drake as of e7aa6fcd.

Some new README content is based off Drake's related README.
@jwnimmer-tri jwnimmer-tri merged commit db9c78f into RobotLocomotion:master Apr 2, 2024
2 checks passed
@jwnimmer-tri jwnimmer-tri deleted the wsg_50_hydro_bubble branch April 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants