Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Continue playback of audio messages in the background #2578

Closed
jacotec opened this issue Oct 23, 2020 · 6 comments · Fixed by #3385
Closed

[Feature] Continue playback of audio messages in the background #2578

jacotec opened this issue Oct 23, 2020 · 6 comments · Fixed by #3385

Comments

@jacotec
Copy link
Contributor

jacotec commented Oct 23, 2020

Description:

Currently the playback of an audio message stops whenever the app goes into the background. I.e. when listening to a 5 minute audio message, the app must stay in the foreground all the time.

Other apps like WhatsApp etc. continue the active playback even when the app is in the background, which allows the use of other apps during playback.

Environment Information:

  • Rocket.Chat Server Version: 3.7.1
  • Rocket.Chat App Version: 4.11.0
  • Device Name: iPhone 11 Pro MAX
  • OS Version: IOS 14.0.1

Steps to reproduce:

  1. Start the playback of an audio message
  2. Put the app in the background
  3. The playback of the audio message immediately stops

Expected behavior:

The playback should continue in the background until the playback is complete or stopped back in the RC app.

Actual behavior:

The playback stops as soon as the app goes into background.

@pratyaksh123
Copy link

pratyaksh123 commented Dec 11, 2020

Hey, I would love to Work on this!

@diegolmello
Copy link
Member

Awesome. Go for it.

pratyaksh123 added a commit to pratyaksh123/RewardZ that referenced this issue Dec 13, 2020
@pratyaksh123
Copy link

I have implemented this feature, but I am not able to commit my changes because of a failed pre-commit hook.

@diegolmello
Copy link
Member

@pratyaksh123 this is our pre-commit hook https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/develop/package.json#L16

You can run locally in order to check what's wrong with your changes.

@pratyaksh123
Copy link

pratyaksh123 commented Dec 14, 2020

This needs to be tested on iOS devices ( unfortunately I can't run this on my iPhone on windows ), I have tested it on android and it works.

@jacotec
Copy link
Contributor Author

jacotec commented Sep 10, 2021

Closed with #3373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants