Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Voice messages improvements #3385

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Conversation

gerzonc
Copy link
Contributor

@gerzonc gerzonc commented Sep 15, 2021

Proposed changes

Change voice message container to m4a which gives correct length in Android, IOS, Chrome, Edge and Firefox
Enable background mode for voice playback, so listening to voice messages is possible when the app is put into background

Issue(s)

Closes #2586
Closes #2578

How to test or reproduce

  • Record a voice message with the app at IOS or Android. The message length is correctly displayed on IOS, Android and the web client
  • Playback a voice message and put the app into background (i.e. by changing to another app) - the playback continues

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello changed the title test changes [IMPROVE] Voice messages improvements Sep 16, 2021
@diegolmello diegolmello marked this pull request as ready for review September 16, 2021 21:04
@diegolmello diegolmello mentioned this pull request Sep 16, 2021
10 tasks
@diegolmello diegolmello merged commit 0871849 into develop Sep 21, 2021
@diegolmello diegolmello deleted the improve.voice-messages-test branch September 21, 2021 14:47
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Marco Jacotec <mj@jacotec.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants