[IMPROVE] Voice messages

[jacotec]

Proposed changes

Change voice message container to m4a which gives correct length in Android, IOS, Chrome, Edge and Firefox
Enable background mode for voice playback, so listening to voice messages is possible when the app is put into background

Issue(s)

Fixes #2586 and #2578

How to test or reproduce

• Record a voice message with the app at IOS or Android. The message length is correctly displayed on IOS, Android and the web client
• Playback a voice message and put the app into background (i.e. by changing to another app) - the playback continues

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

• Fixes wrong length display of voice messages (especially recorded on IOS)
• Continue playback of voice messages when the app is put into background

[gerzonc]

LGTM

[diegolmello]

@jacotec I can't checkout your code to resolve conflicts.

Do you mind giving us permission? https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Thanks!

[jacotec]

@jacotec I can't checkout your code to resolve conflicts.

Do you mind giving us permission? https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Thanks!

Hi @diegolmello
"Allow edits by maintainers" is checked at my PR ... what can I do else?

[diegolmello]

@jacotec Can you update your branch then?
I'll reviewing/merging stuff, but I wait for you if you can do it right away.

[jacotec]

@jacotec Can you update your branch then?
I'll reviewing/merging stuff, but I wait for you if you can do it right away.

@diegolmello Can you help a mid-50's guy who is working 15 years with SVN and who's getting his head into JavaScript and GitHub to fix this voice message stuff how I should do this? ;-)

I've forked the project, updated my fork with my changes, created a PR to the upstream project, enabled "edit by maintainers" ... what can I do to to help you here? What means "update my branch"?

BTW: I'm currently working on #3002 and I just need to iron out a last issue ... what's the deadline for the next version? Would be fine to have the voice message fixes all in one package :-)

[diegolmello]

Easier to fix this: I close this PR, get your code and then I open a separate PR.

If you send me your email, I can add you as co-author so you get credits on the commit.
Can we do it that way?
I can make it in a few, but for sure it'll land next release (beta coming next Tuesday~Wed).

[jacotec]

Easier to fix this: I close this PR, get your code and then I open a separate PR.

If you send me your email, I can add you as co-author so you get credits on the commit.
Can we do it that way?
I can make it in a few, but for sure it'll land next release (beta coming next Tuesday~Wed).

Hi @diegolmello

Sure ... mj -at- jacotec -dot- de ;-)

I'm a bit stuck @ #3002 with a last GUI issue ... if I can't solve this tomorrow, can I send it to you for your opinion? Just thinking of the full package for next week.

[diegolmello]

@jacotec Yep. Thanks.

[jacotec]

@diegolmello How can I contact you in case I'm still stuck tomorrow? Can you send me your email by email? ;-)

[diegolmello]

@jacotec https://open.rocket.chat/direct/diego.mello

[diegolmello]

Closed in favor of #3385