Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.68.0 #11591

Merged
merged 62 commits into from
Jul 28, 2018
Merged

Release 0.68.0 #11591

merged 62 commits into from
Jul 28, 2018

Conversation

sampaiodiego
Copy link
Member

2018-07-27 · 2 ️️️⚠️ · 13 🎉 · 3 🚀 · 23 🐛 · 10 🔍 · 21 👩‍💻👨‍💻

Engine versions

  • Node: 8.11.3
  • NPM: 5.6.0

⚠️ BREAKING CHANGES

  • Remove deprecated /user.roles endpoint (#11493)
  • Update GraphQL dependencies (#11430)

🎉 New features

  • Setting to disable 2FA globally (#11328)
  • Add /users.deleteOwnAccount REST endpoint to an user delete his own account (#11488)
  • Add /roles.list REST endpoint to retrieve all server roles (#11500)
  • Message retention policy and pruning (#11236 by @vynmera)
  • Send user status to client (#11303 by @HappyTobi)
  • Room files search form (#11486)
  • search only default tone emoji Popup search (#10017 by @Joe-mcgee)
  • Privacy for custom user fields (#11332 by @vynmera)
  • Replaced old logo with the new ones (#11491)
  • Sorting channels by number of users in directory (#9972 by @arungalva)
  • Make WebRTC not enabled by default (#11489)
  • Accept resumeToken as query param to log in (#11443)
  • Livechat File Upload (#10514)

🚀 Improvements

  • Set default max upload size to 100mb (#11327)
  • Typing indicators now use Real Names (#11164 by @vynmera)
  • Allow markdown in room topic, announcement, and description including single quotes (#11408)

🐛 Bug fixes

  • New favicons size too small (#11524)
  • Render reply preview with message as a common message (#11534)
  • Unreads counter for new rooms on /channels.counters REST endpoint (#11531)
  • Marked parser breaking announcements and mentions at the start of messages (#11357 by @vynmera)
  • Send Livechat back to Guest Pool (#10731)
  • Add customFields property to /me REST endpoint response (#11496)
  • Invalid permalink URLs for Direct Messages (#11507)
  • Unlimited upload file size not working (#11471)
  • Mixed case channel slugs (#9449 by @soundstorm)
  • SAML issues (#11135 by @arminfelder)
  • Loading and setting fixes for i18n and RTL (#11363)
  • Check for channels property on message object before parsing mentions (#11527)
  • empty blockquote (#11526)
  • Snap font issue for sharp (#11514)
  • RocketChat.settings.get causing memory leak (sometimes) (#11487)
  • Refinements in message popup mentions (#11441)
  • Decrease room leader bar z-index (#11450)
  • Remove title attribute from sidebar items (#11298)
  • Only escape HTML from details in toast error messages (#11459)
  • broadcast channel reply (#11462)
  • Fixed svg for older chrome browsers bug svg render on older chrome #11414 (#11416 by @tpDBL)
  • Wrap custom fields in user profile to new line (#10119 by @PhpXp)
  • Record popup (#11349)
🔍 Minor changes
  • Revert: Mixed case channel slugs [FIX] Mixed case channel slugs #9449 (#11537)
  • Merge master into develop & Set version to 0.68.0-develop (#11536)
  • Regression: Add missing LiveChat permission to allow removing closed rooms (#11423)
  • Update release issue template to use Houston CLI (#11499)
  • Regression: Remove safe area margins from logos (#11508)
  • Regression: Update cachedCollection version (#11561)
  • Regression: nonReactive to nonreactive (#11550)
  • LingoHub based on develop (#11587)
  • Regression: Make message popup user mentions reactive again (#11567)
  • Regression: Fix purge message's translations (#11590)

👩‍💻👨‍💻 Contributors 😍

👩‍💻👨‍💻 Core Team 🤓

renatobecker and others added 30 commits July 13, 2018 13:41
* Fixed svg for older chrome browsers bug #11414

* Created own check for Chrome
* Only escape HTML from details in toast error messages

* Refactor reducer
* Fix typos

* Remove title attribute from sidebar items

* Revert "Remove title attribute from sidebar items"

This reverts commit 691a447.

* Add title attribute in sidebar items if needed

* Replace mouseover with mouseenter
* Remove HTML escaping on input of room topic, announcement, description

* Render channel settings with markdown

* Add markdown rendering for room topic

* Escape messages of changes in room topic, announcement, description

* Apply markdown in Livechat visitor info topic
Related to #6515.
Recreation of #10891 as that PR got rather messy.
Closes #10979
Closes #8070

When using custom user fields, you might not want to expose rather private fields like `statusConnection` or their email. Currently, to view custom fields, the `view-full-other-user-info` permission is required.
This PR adds an optional `public` field to all `Accounts_CustomFields` entries, which overrides this requirement, so users without the permission can see the field.

## Setup
![2018-05-27_18-35-38](https://user-images.githubusercontent.com/39674991/40589494-7a6fa220-61ee-11e8-8acc-48cee8ed72bc.png)
![2018-05-27_18-35-46](https://user-images.githubusercontent.com/39674991/40589495-7a8aedaa-61ee-11e8-9be5-208d0a950c65.png)
_The `public` field will default to false when not specified._
## Preview
Any user can see all of their own fields.
![2018-05-27_18-36-40](https://user-images.githubusercontent.com/39674991/40589498-7ad3fd2e-61ee-11e8-9a9e-6b7411105a75.png)
However, if they do not have the `view-full-other-user-info` permission, they can only see others' public fields.
![2018-05-27_18-36-34](https://user-images.githubusercontent.com/39674991/40589497-7abb6606-61ee-11e8-9866-77f2c9bff6e3.png)
Of course, those with the `view-full-other-user-info` permission can always see all fields.
![2018-05-27_18-36-19](https://user-images.githubusercontent.com/39674991/40589496-7aa37dc0-61ee-11e8-9b37-0dbd8bbe4731.png)
Closes #10872

- [x] Removes email addresses from default user search (**impacts on search bar too**)
- [x] Suggests first users that sent text messages in the room
- [x] All users are listed together with real name and status
* Keep only one PhotoSwipe gallery open

* Refactor PhotoSwipe code

* Handle preloading in PhotoSwipe

* Use common fixCordova helper in uploadFilesList

* Fix log helper

* Fix the server-side handling of room_files collection

* Improvements in uploadedFilesList

* Adjust margins

* Add file name filter for uploaded files

* Add search form for uploaded files

* Add missing translation key

* Fix indentation in template

* Add layout changes

* Fix progressive loading in uploaded files list

* Add rel="noopener noreferrer" to links in uploaded files list

* Rename parameter

* Handle image loading for PhotoShipe gallery

* Show images in uploaded files list in PhotoSwipe gallery

* Add escapeCssUrl helper

* Escape thumbnail URL in uploaded files list

* Force download on uploaded files list

* Add a publication for uploaded files list with search text

* Update roomFiles.js

* Update roomFilesWithSearchText.js
NEW: Send user status to client.

I added the functionality to the server to implement some new features for the desktop client.

With the global event we can listen on the status / status-change of the user, and show special icons or a colored title at the menu bar.
* meteor update swydo:graphql
* Fix GraphQL tests
<!-- INSTRUCTION: Your Pull Request name should start with one of the following tags -->
<!-- [NEW] For new features -->
<!-- [FIX] For bug fixes -->
<!-- [BREAK] For pull requests including breaking changes -->

<!-- INSTRUCTION: Inform the issue number that this PR closes, or remove the line below -->


<!-- INSTRUCTION: Link to a https://github.com/RocketChat/docs PR with added/updated documentation or an update to the missing/outdated documentation list, see https://rocket.chat/docs/contributing/documentation/  -->

<!-- INSTRUCTION: Tell us more about your PR with screen shots if you can -->
Part of an attempt to improve #11145

If the admin has "Use Real Name" on, typing indicators now show the real name, making life a lot easier for those who auto-generate usernames or otherwise have usernames that don't correlate with the user.

**Before, or with "Use Real Name" off**
![2018-06-15_21-52-59](https://user-images.githubusercontent.com/39674991/41487087-7cb40974-70e7-11e8-89c5-0336cb9e8592.png)

**After, with "Use Real Name" on**
![2018-06-15_21-53-15](https://user-images.githubusercontent.com/39674991/41487094-8540e01c-70e7-11e8-89f8-acefa1e9ae1a.png)

Enjoy!
* [FIX] Logs safe area

* Remove Copy title

* Fix logo spaces and sizes
Closes #6749
Closes #8321
Closes #9374
Closes #2700
Closes #2639
Closes #2355 
Closes #1861
Closes #8757
Closes #7228
Closes #10870
Closes #6193 
Closes #11299
Closes #11468
Closes #9317
Closes #11300 (will incorporate a fix to this PR's issue)
Closes #11046 (will incorporate a fix to this PR's issue)
Contributes to #5944 
Contributes to #11475
_...and possibly more!_

This PR makes deleting messages (automatically and manually) a lot easier on Rocket.Chat.

- [X] Implement a bulk message deletion notification, to quickly push large message deletions to users without reload
  - [X] Use it in `rooms.cleanHistory`
  - [X] Use it in user deletions
- [X] Completely remove cleanChannelHistory as required by v0.67
  - [X] Remove server method `cleanChannelHistory`
  - [X] Remove REST API `channels.cleanHistory`
- [x] Implement a sidebar option to clean history
  - [x] Basic implementation
  - [x] Allow excluding pinned messages
  - [x] Allow attachment-only mode
  - [x] Allow specifying user(s) to narrow down to
    - [x] Also update REST API
    - [x] Also update docs
  - [x] Break the deletion into multiple different requests, so the client can keep track of progress
  - [x] Clear animation / progress bar for deleting
- [x] Retention policy
  - [X] Global, set by admin
    - [X] Global timer that runs every second and deletes messages over the set limit
      - [X] Can change its timer's resolution to prevent insane CPU overhead
    - [X] Admin can decide what room types to target (channels, groups and/or DMs)
    - [X] Allow excluding pinned messages
    - [X] Allow attachment-only mode
  - [x] Per-channel, set by those with a new permission
    - [x] Disabled when master switch off
    - [x] Set in channel info
    - [x] Can override global policy with a switch that requires `edit-privileged-setting`
    - [x] Allow excluding pinned messages
    - [x] Allow attachment-only mode
    - [x] Uses same global timer for cleanup
  - [X] Message at start of channel history / in channel info if there is a retention policy set
  - [x] Message in channel info if there is a retention policy set on that channel specifically
- [X] Make cleaning history also delete files (completely!)
  - [X] Manual purging
  - [X] Automatic purging
- [x] Make other deletions also delete files
  - [x] User deletion
    - [X] Own messages
    - [x] DMs with them's partner messages
  - [x] Room deletion
- [x] Cleanup
- [x] Finish related [docs](https://github.com/RocketChat/docs/pull/815)
- [x] Link to the docs in the settings

Please suggest any cool changes/additions! Any support is greatly appreciated.

**Breaking change:** This PR removes REST API endpoint `channels.cleanHistory` and Meteor callable `cleanChannelHistory` as per the protocol specified for them.

![bzzzzzzzz](https://user-images.githubusercontent.com/39674991/41799087-56d1dea0-7670-11e8-94c0-bc534b1f832d.png)
* Install fontconfig for snap

* Add fontconfig environment variables so sharp can find fonts
…ntions (#11527)

This is solves a bug introduced by #11165 when replying messages that contain channel mentions.
MarcosSpessatto and others added 25 commits July 20, 2018 23:10
* Fix the 'forward chat' when using the 'Guest Pool' routing method.

* Fix Livechat redirect URL.

* Improved the logic returning the livechat room to the queue.
…of messages (#11357)

* Fix announcements and mentions

* rename to RocketChatMarkdownInline
Merge master into develop & Set version to 0.68.0-develop
* Make message popup user mentions reactive again

* Add e2e test for user mentions in message popup

* Avoid call functions twice

* Prepare test data using the REST API

* Remove @watch from test description

* Logout before testing
Manual push by LingoHub User: Rodrigo Nascimento.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-11591 July 28, 2018 02:14 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.