Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Federation delete room event not being dispatched #16861

Merged
merged 2 commits into from
Apr 1, 2020
Merged

[FIX] Federation delete room event not being dispatched #16861

merged 2 commits into from
Apr 1, 2020

Conversation

1rV1N-git
Copy link
Contributor

@1rV1N-git 1rV1N-git commented Mar 12, 2020 •
edited by sampaiodiego
Loading

Closes #15823

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lgtm-com
Copy link

lgtm-com bot commented Mar 12, 2020

This pull request introduces 1 alert when merging 0034ac5 into 9c21ff4 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@1rV1N-git 1rV1N-git mentioned this pull request Mar 31, 2020
Merged
@sampaiodiego sampaiodiego added this to the 3.0.10 milestone Apr 1, 2020
sampaiodiego
sampaiodiego approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @1rV1N-git .. good to know there are people out there trying out federation. =)

@sampaiodiego sampaiodiego changed the title [FIX] ReferenceError: dispatchEvent is not defined [FIX] Federation delete room event not being dispatched Apr 1, 2020
@sampaiodiego sampaiodiego merged commit 5eb8066 into RocketChat:develop Apr 1, 2020
sampaiodiego pushed a commit that referenced this pull request Apr 1, 2020
@1rV1N-git @sampaiodiego
[FIX] Federation delete room event not being dispatched (#16861)
5348895
@sampaiodiego sampaiodiego mentioned this pull request Apr 1, 2020
Merged
@1rV1N-git 1rV1N-git deleted the patch-1 branch April 2, 2020 07:23
gabriellsh added a commit that referenced this pull request Apr 2, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
8b98d21 
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (304 commits)
  [FIX] Omnichannel endpoint `inquiries.getOne` returning only queued inquiries (#17132)
  Fix design review (#17133)
  Regression: Direct message creation by REST (#17109)
  Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128)
  Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127)
  Regression: IE11 Support (#17125)
  [FIX] Federation delete room event not being dispatched (#16861)
  [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878)
  New Troubleshoot section for disabling features (#17114)
  Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118)
  [NEW] Discussions: Inherit the public status of parent channel (#17070)
  Regression: fix fuselage import, remove directory css (#17116)
  [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115)
  Regression: Remove old and closed Omnichannel inquiries (#17113)
  [FIX] Member's list only filtering users already on screen (#17110)
  Single codebase announcement (#17081)
  [NEW] Directory page refactored, new user's bio field (#17043)
  [NEW] Sort List, View Mode and Group by revamp (#17103)
  Regression: Files were been deleted when deleting users as last members of private rooms (#17111)
  Regression: Block users was not possible for 1:1 DMs (#17105)
  ...
ggazzo added a commit that referenced this pull request Apr 3, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into wrap…
e27cdbf 
…per-call-meteor-methods-over-rest

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128)
  Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127)
  Regression: IE11 Support (#17125)
  [FIX] Federation delete room event not being dispatched (#16861)
  [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878)
  New Troubleshoot section for disabling features (#17114)
  Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118)
  [NEW] Discussions: Inherit the public status of parent channel (#17070)
  Regression: fix fuselage import, remove directory css (#17116)
  [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115)
  Regression: Remove old and closed Omnichannel inquiries (#17113)
  [FIX] Member's list only filtering users already on screen (#17110)
  Single codebase announcement (#17081)
  [NEW] Directory page refactored, new user's bio field (#17043)
  [NEW] Sort List, View Mode and Group by revamp (#17103)
  Regression: Files were been deleted when deleting users as last members of private rooms (#17111)
  Regression: Block users was not possible for 1:1 DMs (#17105)
  Regression: Collapsible elements didn't respect attachment parameter. (#16994)
  [FIX] Apps Engine notifyRoom sending notification to wrong users (#17093)
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.10
Development

Successfully merging this pull request may close these issues.

Federated room cannot be deleted (throws an error on server)
3 participants
@1rV1N-git @CLAassistant @sampaiodiego