-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Directory page refactored, new user's bio field #17043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ggazzo
commented
Mar 27, 2020
•
edited
Loading
edited
tassoevan
previously requested changes
Mar 27, 2020
Co-Authored-By: Tasso Evangelista <tasso.evangelista@rocket.chat>
…to feat/directory * 'feat/directory' of github.com:RocketChat/Rocket.Chat: Update app/ui/client/views/app/components/Directory/ChannelsTab.js
…to feat/directory * 'feat/directory' of github.com:RocketChat/Rocket.Chat: Show correctly and search by discussions Fix: Notifications of Group DM were not showing the room name (#17058) Fix: Last message of Group DMs not showing the sender (#17059) Regression: Invite links working for group DMs (#17056) Regression: Do not refresh statistics when opening the info panel (#17060) Regression: Fix removing user not removing his 1-on-1 DMs (#17057)
…to feat/directory * 'feat/directory' of github.com:RocketChat/Rocket.Chat: Add bio as default field for searching Remove topic column from users tab Featured on top always [NEW] Home button on sidebar (#17052) [IMPROVE] Repeat “Reply In Thread” and “Add Reaction” inside the message actions menu (#17073) Make DirectMessageRoomType.isGroupChat() accept null roomData (#17074) [IMPROVE] Tab Bar actions reorder (#17072) Regression: Overwrite model functions on EE only when license applied (#17061) Regression: users.setStatus throwing an error if message is empty (#17036) Regression: Omnichannel notification on new conversations displaying incorrect information (#16346)
This pull request introduces 1 alert when merging 146b30f into 6935e49 - view on LGTM.com new alerts:
|
…/directory * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Check Omnichannel routing system before emitting queue changes (#17087) [FIX] Emit livechat events to instace only (#17086) [NEW] Add update method for user bridge (#17077) [FIX] Verification email body (#17062) Add User’s index for field `appId` (#17075) Fix omnichannel agent activity monitor (#16979)
…to feat/directory * 'feat/directory' of github.com:RocketChat/Rocket.Chat: Fix tests Use text index to search for users
rodrigok
changed the title
[NEW] Directory page react
[NEW] Directory page refactored, new user's bio field and merge of sorting and view mode menus
Mar 31, 2020
ggazzo
changed the title
[NEW] Directory page refactored, new user's bio field and merge of sorting and view mode menus
[NEW] Directory page refactored, new user's bio field
Mar 31, 2020
tassoevan
requested changes
Mar 31, 2020
tassoevan
requested changes
Mar 31, 2020
Co-Authored-By: Tasso Evangelista <tasso.evangelista@rocket.chat>
Co-Authored-By: Tasso Evangelista <tasso.evangelista@rocket.chat>
…to feat/directory * 'feat/directory' of github.com:RocketChat/Rocket.Chat: Update app/lib/server/functions/saveUser.js Update app/channel-settings/server/methods/saveRoomSettings.js Regression: Block users was not possible for 1:1 DMs (#17105) Regression: Collapsible elements didn't respect attachment parameter. (#16994) [FIX] Apps Engine notifyRoom sending notification to wrong users (#17093) Update .eslintrc Bump version to 3.0.8 Regression: Remove model observe that was used to control the status of the Omnichannel agents (#17078) [FIX] Emit livechat events to instace only (#17086) Reduce notifyUser propagation (#17088) [FIX] Error when websocket received status update event (#17089) [FIX] Error when websocket received status update event (#17089) Reduce notifyUser propagation (#17088) Regression: Remove model observe that was used to control the status of the Omnichannel agents (#17078)
tassoevan
approved these changes
Apr 1, 2020
gabriellsh
added a commit
that referenced
this pull request
Apr 2, 2020
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: (304 commits) [FIX] Omnichannel endpoint `inquiries.getOne` returning only queued inquiries (#17132) Fix design review (#17133) Regression: Direct message creation by REST (#17109) Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128) Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127) Regression: IE11 Support (#17125) [FIX] Federation delete room event not being dispatched (#16861) [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878) New Troubleshoot section for disabling features (#17114) Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118) [NEW] Discussions: Inherit the public status of parent channel (#17070) Regression: fix fuselage import, remove directory css (#17116) [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115) Regression: Remove old and closed Omnichannel inquiries (#17113) [FIX] Member's list only filtering users already on screen (#17110) Single codebase announcement (#17081) [NEW] Directory page refactored, new user's bio field (#17043) [NEW] Sort List, View Mode and Group by revamp (#17103) Regression: Files were been deleted when deleting users as last members of private rooms (#17111) Regression: Block users was not possible for 1:1 DMs (#17105) ...
ggazzo
added a commit
that referenced
this pull request
Apr 3, 2020
…per-call-meteor-methods-over-rest * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128) Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127) Regression: IE11 Support (#17125) [FIX] Federation delete room event not being dispatched (#16861) [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878) New Troubleshoot section for disabling features (#17114) Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118) [NEW] Discussions: Inherit the public status of parent channel (#17070) Regression: fix fuselage import, remove directory css (#17116) [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115) Regression: Remove old and closed Omnichannel inquiries (#17113) [FIX] Member's list only filtering users already on screen (#17110) Single codebase announcement (#17081) [NEW] Directory page refactored, new user's bio field (#17043) [NEW] Sort List, View Mode and Group by revamp (#17103) Regression: Files were been deleted when deleting users as last members of private rooms (#17111) Regression: Block users was not possible for 1:1 DMs (#17105) Regression: Collapsible elements didn't respect attachment parameter. (#16994) [FIX] Apps Engine notifyRoom sending notification to wrong users (#17093)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.