Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message parsing and rendering - Phase 1 #19654

Merged
merged 46 commits into from
Dec 10, 2020
Merged

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Nov 23, 2020

Proposed changes

It removes dependency from underscore.string and let parsing options changes decoupled from the rendering process itself.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan changed the title feat/message-parsing [IMPROVE] Message parsing and rendering Nov 23, 2020
@tassoevan tassoevan added this to the 3.10.0 milestone Nov 25, 2020
@ggazzo ggazzo marked this pull request as ready for review December 1, 2020 03:46
ggazzo
ggazzo previously approved these changes Dec 1, 2020
@tassoevan tassoevan dismissed ggazzo’s stale review December 1, 2020 03:47

Dodói demais

@tassoevan tassoevan marked this pull request as draft December 1, 2020 03:49
@tassoevan tassoevan changed the title [IMPROVE] Message parsing and rendering [IMPROVE] Message parsing and rendering - Phase 1 Dec 9, 2020
@tassoevan tassoevan changed the title [IMPROVE] Message parsing and rendering - Phase 1 Message parsing and rendering - Phase 1 Dec 9, 2020
@tassoevan tassoevan requested a review from a team December 9, 2020 22:30
@tassoevan tassoevan marked this pull request as ready for review December 9, 2020 22:30
@tassoevan tassoevan merged commit 7a21974 into develop Dec 10, 2020
@tassoevan tassoevan deleted the feat/message-parsing branch December 10, 2020 05:26
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants