Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Too many REST API requests #26330

Merged
merged 7 commits into from
Aug 10, 2022
Merged

[FIX] Too many REST API requests #26330

merged 7 commits into from
Aug 10, 2022

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 21, 2022

Proposed changes (including videos or screenshots)

Uses React Query cache as an alternative for querying data "sorta" real time.

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan requested a review from a team July 21, 2022 15:43
@tassoevan tassoevan added this to the 5.0.1 milestone Jul 21, 2022
@tassoevan tassoevan requested a review from sampaiodiego July 21, 2022 18:42
@tassoevan tassoevan marked this pull request as ready for review July 21, 2022 18:42
@tassoevan tassoevan requested a review from a team as a code owner July 21, 2022 18:42
d-gubert
d-gubert previously approved these changes Jul 21, 2022
ggazzo
ggazzo previously approved these changes Jul 26, 2022
@ggazzo ggazzo modified the milestones: 5.0.1, 5.1.0 Jul 26, 2022
@tassoevan tassoevan dismissed stale reviews from ggazzo and d-gubert via 875abca August 9, 2022 22:09
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #26330 (875abca) into develop (9e5c9a2) will increase coverage by 0.19%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26330      +/-   ##
===========================================
+ Coverage    37.88%   38.07%   +0.19%     
===========================================
  Files          749      749              
  Lines        18673    18665       -8     
  Branches      1459     1455       -4     
===========================================
+ Hits          7074     7107      +33     
+ Misses       11372    11336      -36     
+ Partials       227      222       -5     
Flag Coverage Δ
e2e 38.07% <87.50%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 10, 2022
@ggazzo ggazzo merged commit 7b94323 into develop Aug 10, 2022
@ggazzo ggazzo deleted the fix/ease-api-requests branch August 10, 2022 03:15
gabriellsh added a commit that referenced this pull request Aug 12, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (34 commits)
  Chore: update fuselage rounded edition  (#26540)
  [FIX] LDAP fails to sync teams when the user DN has escaped characters. (#26535)
  [FIX] Allow normal user to open apps contextual bar (#26495)
  Chore: restrict `.only` (#26537)
  [FIX] Endpoints not working when using "Use Real Name" setting (#26530)
  [NEW] `Home` page (#25734)
  Chore: ModalFooterControllers adoption (#26445)
  Chore: create roomNameExists endpoint (#26386)
  Chore: Improve test for livechat  (#26527)
  Chore: Fix UiKit dependency issue for Livechat (#26534)
  [FIX] Too many REST API requests (#26330)
  Chore: Mocha handling multiple React instances (#26513)
  Chore: Convert `LivechatCustomField` model to raw model (#26446)
  i18n: Language update from LingoHub 🤖 on 2022-08-08Z (#26508)
  [FIX] Open team after room not found page (#26264)
  Chore: Refactor ReportMessage Modal to React Component (#26478)
  Chore: Fix lint issues (#26531)
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants