Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Convert LivechatCustomField model to raw model #26446

Merged
merged 9 commits into from
Aug 10, 2022

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team August 2, 2022 15:23
@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2022

This pull request fixes 1 alert when merging 038f7bb into f555889 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #26446 (910b017) into develop (7b8be57) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26446      +/-   ##
===========================================
- Coverage    38.01%   37.89%   -0.12%     
===========================================
  Files          749      749              
  Lines        18668    18668              
  Branches      1457     1457              
===========================================
- Hits          7097     7075      -22     
- Misses       11343    11370      +27     
+ Partials       228      223       -5     
Flag Coverage Δ
e2e 37.89% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman
KevLehman previously approved these changes Aug 9, 2022
ggazzo
ggazzo previously approved these changes Aug 9, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 9, 2022
@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2022

This pull request fixes 1 alert when merging 7ca54c6 into 2ebd463 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@sampaiodiego sampaiodiego force-pushed the convert-livechat-custom-field-model branch from 3bfe641 to af7d2e5 Compare August 9, 2022 14:34
KevLehman
KevLehman previously approved these changes Aug 9, 2022
@KevLehman
Copy link
Contributor

ui-context is failing, so we should be good 😬

@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2022

This pull request fixes 1 alert when merging af7d2e5 into 37d8f59 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2022

This pull request fixes 1 alert when merging a8d1d82 into 37d8f59 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2022

This pull request fixes 1 alert when merging bbce025 into 9ae6a07 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@sampaiodiego
Copy link
Member Author

let's see now 👀

@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2022

This pull request fixes 1 alert when merging 71da0fa into 9e5c9a2 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2022

This pull request fixes 1 alert when merging 910b017 into 204fe91 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@kodiakhq kodiakhq bot merged commit 2901011 into develop Aug 10, 2022
@kodiakhq kodiakhq bot deleted the convert-livechat-custom-field-model branch August 10, 2022 00:09
gabriellsh added a commit that referenced this pull request Aug 12, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (34 commits)
  Chore: update fuselage rounded edition  (#26540)
  [FIX] LDAP fails to sync teams when the user DN has escaped characters. (#26535)
  [FIX] Allow normal user to open apps contextual bar (#26495)
  Chore: restrict `.only` (#26537)
  [FIX] Endpoints not working when using "Use Real Name" setting (#26530)
  [NEW] `Home` page (#25734)
  Chore: ModalFooterControllers adoption (#26445)
  Chore: create roomNameExists endpoint (#26386)
  Chore: Improve test for livechat  (#26527)
  Chore: Fix UiKit dependency issue for Livechat (#26534)
  [FIX] Too many REST API requests (#26330)
  Chore: Mocha handling multiple React instances (#26513)
  Chore: Convert `LivechatCustomField` model to raw model (#26446)
  i18n: Language update from LingoHub 🤖 on 2022-08-08Z (#26508)
  [FIX] Open team after room not found page (#26264)
  Chore: Refactor ReportMessage Modal to React Component (#26478)
  Chore: Fix lint issues (#26531)
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants