Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Endpoints not working when using "Use Real Name" setting #26530

Merged
merged 10 commits into from
Aug 10, 2022

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

The list of endpoints affected is:

  • /api/v1/channels.list
  • /api/v1/channels.list.joined
  • /api/v1/groups.list
  • /api/v1/groups.listAll
  • /api/v1/im.list
  • /api/v1/im.list.everyone

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner August 9, 2022 19:29
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #26530 (f42d31f) into develop (6953c06) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26530      +/-   ##
===========================================
- Coverage    38.11%   38.09%   -0.03%     
===========================================
  Files          759      759              
  Lines        18831    18831              
  Branches      1459     1459              
===========================================
- Hits          7178     7174       -4     
- Misses       11428    11434       +6     
+ Partials       225      223       -2     
Flag Coverage Δ
e2e 38.09% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 10, 2022
@kodiakhq kodiakhq bot merged commit 9d818a7 into develop Aug 10, 2022
@kodiakhq kodiakhq bot deleted the fix-endpoints-returning-last-message branch August 10, 2022 20:09
@sampaiodiego sampaiodiego added this to the 5.0.3 milestone Aug 10, 2022
@sampaiodiego sampaiodiego mentioned this pull request Aug 11, 2022
gabriellsh added a commit that referenced this pull request Aug 12, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (34 commits)
  Chore: update fuselage rounded edition  (#26540)
  [FIX] LDAP fails to sync teams when the user DN has escaped characters. (#26535)
  [FIX] Allow normal user to open apps contextual bar (#26495)
  Chore: restrict `.only` (#26537)
  [FIX] Endpoints not working when using "Use Real Name" setting (#26530)
  [NEW] `Home` page (#25734)
  Chore: ModalFooterControllers adoption (#26445)
  Chore: create roomNameExists endpoint (#26386)
  Chore: Improve test for livechat  (#26527)
  Chore: Fix UiKit dependency issue for Livechat (#26534)
  [FIX] Too many REST API requests (#26330)
  Chore: Mocha handling multiple React instances (#26513)
  Chore: Convert `LivechatCustomField` model to raw model (#26446)
  i18n: Language update from LingoHub 🤖 on 2022-08-08Z (#26508)
  [FIX] Open team after room not found page (#26264)
  Chore: Refactor ReportMessage Modal to React Component (#26478)
  Chore: Fix lint issues (#26531)
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants