Chore: Refactor WebdavFilePicker Modal to React Component #26422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 6 alerts when merging 6a8633a into b11bab5 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging a28ef34 into a97e926 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## develop #26422 +/- ##
========================================
Coverage 38.05% 38.05%
========================================
Files 745 745
Lines 18625 18622 -3
Branches 1412 1412
========================================
Hits 7087 7087
+ Misses 11318 11314 -4
- Partials 220 221 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Aug 9, 2022
ggazzo
added
stat: QA skipped
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Aug 9, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Bypass turbo cache on `ui-contexts` (#26526) Chore: Refactor WebdavFilePicker Modal to React Component (#26422) [FIX] Chats holds to load history for some time (#26425) [FIX] Decrypt E2EE messages on thread list (#26133) Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498) Chore: Convert `client/views/account/preferences` folder to ts (#26496)
gabriellsh
added a commit
that referenced
this pull request
Aug 9, 2022
…e/refactor-reportMessage-modal * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Don't wrap wrap up notes (#26375) [IMPROVE] OTR refactoring (#24757) [FIX] Prevent VoIP issues during disconnection when network failed (#26321) Chore: Bypass turbo cache on `ui-contexts` (#26526) Chore: Refactor WebdavFilePicker Modal to React Component (#26422) [FIX] Chats holds to load history for some time (#26425) [FIX] Decrypt E2EE messages on thread list (#26133) Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
This was referenced Aug 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Closes #24385
Closes #24775
Closes #24128
Steps to test or reproduce
Further comments