Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bypass turbo cache on ui-contexts #26526

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Aug 9, 2022

Proposed changes (including videos or screenshots)

Skips cache for building @rocket.chat/ui-contexts, avoiding Turborepo issues with a symlink.

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 9, 2022
@tassoevan tassoevan marked this pull request as ready for review August 9, 2022 14:51
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #26526 (243896f) into develop (37d8f59) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26526      +/-   ##
===========================================
+ Coverage    37.95%   38.07%   +0.12%     
===========================================
  Files          747      747              
  Lines        18632    18632              
  Branches      1417     1417              
===========================================
+ Hits          7071     7095      +24     
+ Misses       11340    11312      -28     
- Partials       221      225       +4     
Flag Coverage Δ
e2e 38.07% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 5f5b228 into develop Aug 9, 2022
@kodiakhq kodiakhq bot deleted the chore/skip-cache branch August 9, 2022 16:04
gabriellsh added a commit that referenced this pull request Aug 9, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Bypass turbo cache on `ui-contexts` (#26526)
  Chore: Refactor WebdavFilePicker Modal to React Component (#26422)
  [FIX] Chats holds to load history for some time (#26425)
  [FIX] Decrypt E2EE messages on thread list (#26133)
  Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
  Chore: Convert `client/views/account/preferences` folder to ts (#26496)
gabriellsh added a commit that referenced this pull request Aug 9, 2022
…e/refactor-reportMessage-modal

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  Chore: Bypass turbo cache on `ui-contexts` (#26526)
  Chore: Refactor WebdavFilePicker Modal to React Component (#26422)
  [FIX] Chats holds to load history for some time (#26425)
  [FIX] Decrypt E2EE messages on thread list (#26133)
  Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants