Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Convert client/views/account/preferences folder to ts #26496

Merged
merged 12 commits into from
Aug 8, 2022

Conversation

juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@juliajforesti juliajforesti requested a review from a team August 5, 2022 19:36
@juliajforesti juliajforesti requested a review from a team as a code owner August 5, 2022 19:36
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #26496 (4f1fd37) into develop (f74ba4e) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26496      +/-   ##
===========================================
+ Coverage    37.97%   38.08%   +0.11%     
===========================================
  Files          745      745              
  Lines        18625    18625              
  Branches      1412     1412              
===========================================
+ Hits          7072     7093      +21     
+ Misses       11334    11309      -25     
- Partials       219      223       +4     
Flag Coverage Δ
e2e 38.08% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 8, 2022
@kodiakhq kodiakhq bot merged commit f79e8ed into develop Aug 8, 2022
@kodiakhq kodiakhq bot deleted the improve/convert-client/views/account/preferences branch August 8, 2022 15:33
gabriellsh added a commit that referenced this pull request Aug 9, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Bypass turbo cache on `ui-contexts` (#26526)
  Chore: Refactor WebdavFilePicker Modal to React Component (#26422)
  [FIX] Chats holds to load history for some time (#26425)
  [FIX] Decrypt E2EE messages on thread list (#26133)
  Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
  Chore: Convert `client/views/account/preferences` folder to ts (#26496)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng day stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants