fix!: api login should not suggest which credential is wrong #32086
+33
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a236e2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32086 +/- ##
===========================================
- Coverage 54.77% 54.73% -0.05%
===========================================
Files 2298 2296 -2
Lines 50708 50704 -4
Branches 10374 10373 -1
===========================================
- Hits 27775 27752 -23
- Misses 20440 20463 +23
+ Partials 2493 2489 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
changed the title
KevLehman
reviewed
Mar 27, 2024
it could be and we could discuss hours about. there is no way to fix it without changing the payload, so there is no other way to patch. so far its planned to be released only at 7.0 (already a major). so the discussion if its or not a break is a bit subjective. until now, being released only on 7.0 its a break. if someone decides to patch this, restoring the old behavior, so its a regular patch, at least the changeset will not complain about it It is worth mentioning that this was once the default behavior, and unintentionally changed. look the original file comment
|
KevLehman
previously approved these changes
Mar 27, 2024
tiagoevanp
reviewed
Mar 27, 2024
ggazzo
changed the title
sampaiodiego
approved these changes
Mar 28, 2024
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2024
* develop: (71 commits) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108) chore: Create/Edit room consistency (#31960) chore: Remove references to EE code from the app events (#31926) test(Livechat): Clean up after registerGuest() test (#32092) test: make presence api tests fully independent (#31782) test: make roles fully independent (#31783) chore: bump version to 7.0.0-develop test: make login api tests fully independent (#31786) fix!: api login should not suggest which credential is wrong (#32086) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Apparently at some point the
_runLoginHandlersfunction became asynchronous, thwarting our efforts to obfuscate what the reason for the login rejection was.Instead of returning
Incorrect Passwordits going to returnUnauthorizedas expectedIssue(s)
Steps to test or reproduce
Further comments