Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(livechat): File upload settings #32060

Merged
merged 2 commits into from
Apr 3, 2024
Merged

test(livechat): File upload settings #32060

merged 2 commits into from
Apr 3, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Mar 25, 2024 •
edited
Loading

CORE-216

Adds basic file upload tests for livechat, tests if:

  • Can drag & drop txt files
  • Can drag & drop lst files
  • Drag & drop permissions (fileupload enabled, disabled, etc...)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0717c9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.79%. Comparing base (fa9c905) to head (0717c9e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32060      +/-   ##
===========================================
- Coverage    54.86%   54.79%   -0.08%     
===========================================
  Files         2299     2301       +2     
  Lines        50788    50797       +9     
  Branches     10392    10376      -16     
===========================================
- Hits         27866    27834      -32     
- Misses       20428    20458      +30     
- Partials      2494     2505      +11
Flag Coverage Δ
e2e 53.72% <ø> (-0.14%) ⬇️
e2e-api 40.11% <ø> (ø)
unit 75.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler force-pushed the livechat-file-upload branch 2 times, most recently from dbe066b to 2a1747c Compare March 26, 2024 14:26
@MartinSchoeler MartinSchoeler marked this pull request as ready for review March 26, 2024 17:14
@MartinSchoeler MartinSchoeler requested review from a team as code owners March 26, 2024 17:15
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 27, 2024
@scuciatto
Copy link
Member

Please, add some description to this PR. Although this is a test, we should have a more detailed description.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 27, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 28, 2024
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 3, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is not mergeable
    Please fix the issues and try again
    If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA skipped labels Apr 3, 2024
@ggazzo ggazzo added this to the 7.0 milestone Apr 3, 2024
@ggazzo ggazzo added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Apr 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 3, 2024
@ggazzo ggazzo removed the stat: QA assured Means it has been tested and approved by a company insider label Apr 3, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 3, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 3, 2024
@kodiakhq kodiakhq bot merged commit 6fc2e69 into develop Apr 3, 2024
53 checks passed
@kodiakhq kodiakhq bot deleted the livechat-file-upload branch April 3, 2024 03:35
gabriellsh added a commit that referenced this pull request Apr 4, 2024
@gabriellsh
Merge branch 'develop' into attachmentMessage
dc83009 
* develop: (71 commits)
  fix: search room not reactive after room name changes (#32123)
  test: fix `should edit name of targetChannel` flaky test (#32121)
  fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063)
  chore: Remove duplicated `ChannelDeletionTable` (#32114)
  test(livechat): fix Department flaky test (#32102)
  test(livechat): File upload settings (#32060)
  test: contact center after hook calling wrong endpoint (#32094)
  fix(livechat): registering guest multiple times cause message loss (#32069)
  test: allow csp for livechat tests (#32116)
  chore: Move portals to the portals folder (#32090)
  test: `InitialData.insertAdminUserFromEnv` (#32066)
  fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
  chore: Create/Edit room consistency (#31960)
  chore: Remove references to EE code from the app events (#31926)
  test(Livechat): Clean up after registerGuest() test (#32092)
  test: make presence api tests fully independent (#31782)
  test: make roles fully independent (#31783)
  chore: bump version to 7.0.0-develop
  test: make login api tests fully independent (#31786)
  fix!: api login should not suggest which credential is wrong (#32086)
  ...
gabriellsh added a commit that referenced this pull request Apr 4, 2024
@gabriellsh
Merge remote-tracking branch 'origin' into fix/teamMention
cecb6d7 
* origin:
  refactor: `TeamsChannels` to typescript (#32109)
  fix: search room not reactive after room name changes (#32123)
  test: fix `should edit name of targetChannel` flaky test (#32121)
  fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063)
  chore: Remove duplicated `ChannelDeletionTable` (#32114)
  test(livechat): fix Department flaky test (#32102)
  test(livechat): File upload settings (#32060)
  test: contact center after hook calling wrong endpoint (#32094)
  fix(livechat): registering guest multiple times cause message loss (#32069)
  test: allow csp for livechat tests (#32116)
  chore: Move portals to the portals folder (#32090)
  test: `InitialData.insertAdminUserFromEnv` (#32066)
  fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
@ggazzo ggazzo modified the milestones: 7.0, 6.8 Apr 9, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Milestone
6.8
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinSchoeler @scuciatto @ggazzo @MarcosSpessatto