refactor: TeamsChannels to typescript
#32109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32109 +/- ##
========================================
Coverage 54.77% 54.78%
========================================
Files 2298 2298
Lines 50779 50775 -4
Branches 10395 10405 +10
========================================
+ Hits 27816 27817 +1
+ Misses 20458 20452 -6
- Partials 2505 2506 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dougfabris
changed the title
TeamsChannelItem to typescriptTeamsChannel to typescript
dougfabris
changed the title
TeamsChannel to typescriptTeamsChannels to typescript
tassoevan
requested changes
Apr 3, 2024
apps/meteor/client/views/teams/contextualBar/channels/hooks/useDeleteRoom.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/teams/contextualBar/channels/TeamsChannelsWithData.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/teams/contextualBar/channels/TeamsChannelsWithData.tsx
Outdated
Show resolved
Hide resolved
|
Looks like this PR is not ready to merge, because of the following issues:
|
dionisio-bot
bot
added
stat: QA assured
dionisio-bot
bot
added
stat: ready to merge
dougfabris
force-pushed
the
chore/teamsChannelItem
branch
from
b7892ff to
c338e16
Compare
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
tassoevan
approved these changes
Apr 4, 2024
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2024
* origin: refactor: `TeamsChannels` to typescript (#32109) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
hugocostadev
pushed a commit
that referenced
this pull request
Apr 4, 2024
dionisio-bot
bot
removed
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
CORE-283