Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security alerts fix #1208

Merged
merged 35 commits into from
Mar 31, 2020
Merged

Security alerts fix #1208

merged 35 commits into from
Mar 31, 2020

Conversation

zarkosimic
Copy link
Contributor

@zarkosimic zarkosimic commented Mar 27, 2020

Fixes #1163

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@zarkosimic zarkosimic added WIP Work in progress security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 security/high Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 security always set in addition to specific security severity label, since github filtering is lacking OR labels Mar 27, 2020
@zarkosimic zarkosimic added this to the Hardening v1.0 milestone Mar 27, 2020
@zarkosimic zarkosimic removed the WIP Work in progress label Mar 28, 2020
@hardl hardl removed the security/high Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 label Mar 31, 2020
@marynaKhromova marynaKhromova self-assigned this Mar 31, 2020
@ndricimrr ndricimrr self-assigned this Mar 31, 2020
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zarkosimic zarkosimic merged commit e87fbdf into SAP:master Mar 31, 2020
@zarkosimic zarkosimic deleted the 1163_security_alerts_2 branch March 31, 2020 14:56
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Apr 14, 2020
* master: (28 commits)
  Move npm and other dependencies to devDependencies in core (SAP#1252)
  release 1.0.1 (SAP#1254)
  remove outdated code (SAP#1251)
  Fix GitHub security alerts (SAP#1248)
  Release CLI (SAP#1242)
  add faq question (SAP#1238)
  upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237)
  Mixed styles of note and tip in docu (SAP#1231)
  fix svelte example (SAP#1225)
  Add fromVirtualTreeRoot to linkManager (SAP#1226)
  add fromParent functionality (SAP#1222)
  Getting notified of unresponsive Luigi clients (SAP#1159)
  Optimize documentation for disableAutoLogin (SAP#1223)
  adjust html and css in fiddle after updating Fundamental Library version (SAP#1224)
  Update screenshots in docu (SAP#1218)
  use pushState instead of location.href for oidc (SAP#1213)
  Fix duplicate login logout buttons (SAP#1220)
  Replace docsearch cdn with npm package (SAP#1198)
  Security alerts fix (SAP#1208)
  Set focus on docu search input field (SAP#1196)
  ...
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 security always set in addition to specific security severity label, since github filtering is lacking OR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub and WhiteSource security alerts
4 participants