fix svelte example #1225
Merged
fix svelte example #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kohlerm
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
marynaKhromova,
maxmarkus,
pekura and
zarkosimic
as code owners
|
|
zarkosimic
approved these changes
Apr 6, 2020
| @@ -10,7 +10,7 @@ | |||
| import LuigiClient from '@kyma-project/luigi-client'; | |||
| import { onMount } from 'svelte'; | |||
|
|
|||
| export let message; | |||
| export let message='Hello world' | |||
There was a problem hiding this comment.
Note: This message would be only visible if micro frontend runs without Luigi.
ndricimrr
reviewed
Apr 7, 2020
There was a problem hiding this comment.
npm run dev sometimes fails to run with error message:
sh: line 0: cd: public: No such file or directory
since npm run dev runs three commands concurrently it often may happen that the public folder is not built yet when the second command tries to serve from it.
This issue then goes away if you run npm run dev twice, but it would be good if we somehow had the public folder pre-created to avoid such race condition.
"preinstall": "mkdir public"
Adding a pre-install hook to the scripts could be one solution
ndricimrr
approved these changes
Apr 8, 2020
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Apr 14, 2020
* master: (28 commits) Move npm and other dependencies to devDependencies in core (SAP#1252) release 1.0.1 (SAP#1254) remove outdated code (SAP#1251) Fix GitHub security alerts (SAP#1248) Release CLI (SAP#1242) add faq question (SAP#1238) upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237) Mixed styles of note and tip in docu (SAP#1231) fix svelte example (SAP#1225) Add fromVirtualTreeRoot to linkManager (SAP#1226) add fromParent functionality (SAP#1222) Getting notified of unresponsive Luigi clients (SAP#1159) Optimize documentation for disableAutoLogin (SAP#1223) adjust html and css in fiddle after updating Fundamental Library version (SAP#1224) Update screenshots in docu (SAP#1218) use pushState instead of location.href for oidc (SAP#1213) Fix duplicate login logout buttons (SAP#1220) Replace docsearch cdn with npm package (SAP#1198) Security alerts fix (SAP#1208) Set focus on docu search input field (SAP#1196) ...
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The svelte example does not work for me.
Changes proposed in this pull request: