Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC storage: none #1213

Merged
merged 30 commits into from
Apr 3, 2020
Merged

Conversation

maxmarkus
Copy link
Contributor

Fixes #1182

@maxmarkus maxmarkus added bug Something isn't working auth authorization/authentication labels Mar 27, 2020
@maxmarkus maxmarkus added this to the Hardening v1.0 milestone Mar 27, 2020
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxmarkus
Copy link
Contributor Author

Works as confirmed by @kwiatekus , thanks for reporting!

@zarkosimic zarkosimic self-assigned this Apr 2, 2020
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxmarkus maxmarkus merged commit 7607fa1 into SAP:master Apr 3, 2020
@maxmarkus maxmarkus deleted the 1182-fix-oidc-storage-none branch April 3, 2020 10:22
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Apr 14, 2020
* master: (28 commits)
  Move npm and other dependencies to devDependencies in core (SAP#1252)
  release 1.0.1 (SAP#1254)
  remove outdated code (SAP#1251)
  Fix GitHub security alerts (SAP#1248)
  Release CLI (SAP#1242)
  add faq question (SAP#1238)
  upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237)
  Mixed styles of note and tip in docu (SAP#1231)
  fix svelte example (SAP#1225)
  Add fromVirtualTreeRoot to linkManager (SAP#1226)
  add fromParent functionality (SAP#1222)
  Getting notified of unresponsive Luigi clients (SAP#1159)
  Optimize documentation for disableAutoLogin (SAP#1223)
  adjust html and css in fiddle after updating Fundamental Library version (SAP#1224)
  Update screenshots in docu (SAP#1218)
  use pushState instead of location.href for oidc (SAP#1213)
  Fix duplicate login logout buttons (SAP#1220)
  Replace docsearch cdn with npm package (SAP#1198)
  Security alerts fix (SAP#1208)
  Set focus on docu search input field (SAP#1196)
  ...
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth authorization/authentication bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC storageType:none broken - provider should not redirect to root for hash removal
3 participants