Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal content not displaying issue in Safari #1624

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Fix modal content not displaying issue in Safari #1624

merged 3 commits into from
Sep 17, 2020

Conversation

stanleychh
Copy link
Contributor

Fix #1609

CSS's height 100% doesn't work in Safari this case.
My solution is applying viewport height instead and it works fine, but I am not sure this is the best way.

Please feel free to make a comment if there is any other better solution. Thanks

@stanleychh stanleychh added the bug Something isn't working label Sep 15, 2020
@stanleychh stanleychh added this to the Sprint 13 milestone Sep 15, 2020
@stanleychh stanleychh added the priority/critical Priority indication label Sep 15, 2020
@UlianaMunich UlianaMunich self-assigned this Sep 15, 2020
@JohannesDoberer JohannesDoberer self-assigned this Sep 15, 2020
JohannesDoberer
JohannesDoberer approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this solution. Can't break it ;) , even when we want to change to modal sizes somedays.
👍

UlianaMunich
UlianaMunich suggested changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stanleychh looks good!

@stanleychh stanleychh merged commit 1578eae into SAP:master Sep 17, 2020
@stanleychh stanleychh deleted the 1609-safai-modal-content branch September 17, 2020 10:52
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Sep 23, 2020
@JohannesDoberer
Merge branch 'master' into drawer
52fc3b0 
* master:
  add link (SAP#1630)
  Add NextJS example link (SAP#1632)
  Feature accordion categories (SAP#1623)
  add disableInputHelpers for globalsearch (SAP#1620)
  Show more - blog posts (SAP#1625)
  fix link to the callback section (SAP#1628)
  Fix modal content not displaying issue in Safari (SAP#1624)
@ndricimrr ndricimrr mentioned this pull request Oct 28, 2020
Merged
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@stanleychh
Fix modal content not displaying issue in Safari (SAP#1624)
4199d32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

Assignees

@UlianaMunich UlianaMunich

@JohannesDoberer JohannesDoberer

Labels
bug Something isn't working priority/critical Priority indication
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging this pull request may close these issues.

Content in modal will not be displayed in Safari
3 participants
@stanleychh @UlianaMunich @JohannesDoberer