Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix link to the callback section #1628

Merged
merged 3 commits into from
Sep 17, 2020
Merged

fix link to the callback section #1628

merged 3 commits into from
Sep 17, 2020

Conversation

UlianaMunich
Copy link
Contributor

Fixes #1627

@alexandra-simeonova alexandra-simeonova added this to the Sprint 13 milestone Sep 16, 2020
alexandra-simeonova
alexandra-simeonova approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexandra-simeonova alexandra-simeonova self-assigned this Sep 16, 2020
JohannesDoberer
JohannesDoberer approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohannesDoberer JohannesDoberer self-assigned this Sep 17, 2020
@UlianaMunich UlianaMunich merged commit 6eabb6a into SAP:master Sep 17, 2020
@UlianaMunich UlianaMunich deleted the 1627-callback-linnk-docu branch September 17, 2020 12:02
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Sep 23, 2020
@JohannesDoberer
Merge branch 'master' into drawer
52fc3b0 
* master:
  add link (SAP#1630)
  Add NextJS example link (SAP#1632)
  Feature accordion categories (SAP#1623)
  add disableInputHelpers for globalsearch (SAP#1620)
  Show more - blog posts (SAP#1625)
  fix link to the callback section (SAP#1628)
  Fix modal content not displaying issue in Safari (SAP#1624)
@ndricimrr ndricimrr added the documentation documentation tasks label Oct 28, 2020
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@UlianaMunich
fix link to the callback section (SAP#1628)
d8f45ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@stanleychh stanleychh Awaiting requested review from stanleychh

Assignees

@JohannesDoberer JohannesDoberer

@alexandra-simeonova alexandra-simeonova

Labels
documentation documentation tasks
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging this pull request may close these issues.

Wrong link of callbacks in luigi client docu
4 participants
@UlianaMunich @JohannesDoberer @alexandra-simeonova @ndricimrr