Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show more - blog posts #1625

Merged
merged 10 commits into from
Sep 18, 2020
Merged

Show more - blog posts #1625

merged 10 commits into from
Sep 18, 2020

Conversation

UlianaMunich
Copy link
Contributor

Fixes #1506

Before running the project locally please add 3-5 new blogs.md files at the root folder /blogs

The current step for hiding the blogs is 3. Can be modified anytime at blogeentries.js as a variable numberOfBlogsToBeVisibleOnLoad

@JohannesDoberer JohannesDoberer added this to the Sprint 13 milestone Sep 16, 2020
@JohannesDoberer JohannesDoberer self-assigned this Sep 16, 2020
@maxmarkus maxmarkus changed the title 1506 show more blog posts Show more - blog posts Sep 16, 2020
maxmarkus
maxmarkus suggested changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, just some small things left.

website/landingpage/dev/src/assets/js/app.js Outdated Show resolved Hide resolved
website/landingpage/dev/src/assets/js/app.js Outdated Show resolved Hide resolved
website/landingpage/dev/src/helpers/blogentries.js Outdated Show resolved Hide resolved
website/landingpage/dev/src/pages/blog/overview.html Outdated Show resolved Hide resolved
website/landingpage/dev/src/services/blogprocessor.js Outdated Show resolved Hide resolved
@stanleychh stanleychh self-assigned this Sep 16, 2020
@UlianaMunich @maxmarkus
Update website/landingpage/dev/src/pages/blog/overview.html
a879fd5 
Co-authored-by: Markus <1720843+maxmarkus@users.noreply.github.com>
JohannesDoberer
JohannesDoberer requested changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about if we want these error handling. Maybe also as a follow up task..
Besides that.. fine and I would approve.

website/landingpage/dev/src/assets/js/app.js Show resolved Hide resolved
website/landingpage/dev/src/assets/js/app.js Outdated Show resolved Hide resolved
JohannesDoberer
JohannesDoberer approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍 !

maxmarkus
maxmarkus approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlianaMunich UlianaMunich merged commit d05c3c8 into SAP:master Sep 18, 2020
@UlianaMunich UlianaMunich deleted the 1506-show-more-blog-posts branch September 18, 2020 07:51
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Sep 23, 2020
@JohannesDoberer
Merge branch 'master' into drawer
52fc3b0 
* master:
  add link (SAP#1630)
  Add NextJS example link (SAP#1632)
  Feature accordion categories (SAP#1623)
  add disableInputHelpers for globalsearch (SAP#1620)
  Show more - blog posts (SAP#1625)
  fix link to the callback section (SAP#1628)
  Fix modal content not displaying issue in Safari (SAP#1624)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@UlianaMunich
Show more - blog posts (SAP#1625)
f8b406c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@stanleychh stanleychh stanleychh approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

Assignees

@maxmarkus maxmarkus

@stanleychh stanleychh

@JohannesDoberer JohannesDoberer

Labels
website
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging this pull request may close these issues.

Adapt blog behaviour when there is more than 3/5 blogs on the overview page
5 participants
@UlianaMunich @maxmarkus @stanleychh @JohannesDoberer @alexandra-simeonova