-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite getting started guide #1766
Merged
alexandra-simeonova
merged 9 commits into
SAP:master
from
alexandra-simeonova:improve-getting-started
Jan 18, 2021
Merged
Rewrite getting started guide #1766
alexandra-simeonova
merged 9 commits into
SAP:master
from
alexandra-simeonova:improve-getting-started
Jan 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandra-simeonova
requested review from
hardl,
JohannesDoberer,
legteodav,
maxmarkus,
ndricimrr,
stanleychh and
UlianaMunich
as code owners
December 9, 2020 14:50
UlianaMunich
approved these changes
Dec 11, 2020
legteodav
reviewed
Dec 11, 2020
legteodav
reviewed
Dec 11, 2020
legteodav
reviewed
Dec 11, 2020
legteodav
reviewed
Dec 11, 2020
legteodav
reviewed
Dec 11, 2020
Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> Co-authored-by: legteodav <davide.teodoro.leggieri@sap.com>
legteodav
approved these changes
Dec 15, 2020
hardl
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
legteodav
reviewed
Jan 15, 2021
Luigi is an open source JavaScript framework for micro frontends. It enables you to: | ||
* create a unified user interface for a web application using **Luigi Core**. | ||
* create micro frontends and connect them to the Luigi Core app using **Luigi Client**. | ||
Luigi is an open source JavaScript framework for **micro frontends**. Micro frontends can be used to divide big frontend monoliths into smaller, simpler, independent chunks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Luigi is an open source JavaScript framework for **micro frontends**. Micro frontends can be used to divide big frontend monoliths into smaller, simpler, independent chunks. | |
Luigi is an open source JavaScript framework for **micro frontends**. Micro frontends that can be used to divide big frontend monoliths into smaller, simpler, independent chunks. |
legteodav
reviewed
Jan 15, 2021
<!-- add-attribute:class:success --> | ||
>**TIP:** Go to our [FAQ section](faq.md) to find more detailed answers to questions like *What are micro frontends?* | ||
|
||
The Luigi framework provides configuration options, API functions, and out-of-the-box features which make migrating to a micro frontend architecture easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The Luigi framework provides configuration options, API functions, and out-of-the-box features which make migrating to a micro frontend architecture easier. | |
The Luigi framework provides configuration options, API functions and out-of-the-box features which make migrating to a micro frontend architecture easier. |
legteodav
pushed a commit
to legteodav/luigi
that referenced
this pull request
Jan 19, 2021
legteodav
added a commit
that referenced
this pull request
Jan 19, 2021
* First commit for wc * Adding example for WC * Adding Web Component Documentation * Doc changes * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update client-frameworks-support/client-support-angular/projects/client-support-angular/src/lib/route/luigi-activated-route-snapshot-helper.ts * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Fixing error in luigi core doc * Adding nv documentation * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Adding doc images * Update docs/luigi-core-api.md Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> * Removed unused file * Rename component title * removed white spaces * Adding clazz name to fiddle example, removign examples in the documentation * adding new fiddle component * Adding UI5 Component * Changing label UI5 components * Custom mf for user settings (#1802) * Rewrite getting started guide (#1766) * state-store fix (#1814) Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com> * ng support lib enhancements (#1809) Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> * 1767 different visual appearances (#1790) * Profile setting dialog (#1710) * Read/write settings using core api (#1709) * Dialog box for user settings (#1750) known issue.. grid is not displayed correctly in ie11 * Adding new configuration for enum displayed as buttons * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Changing testdataid with id in html attribute * Adding again testid * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * changing button to segment and group.... * Fixing integration tests Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * merging and resolving conflics * adding new fiddle component * Adding UI5 Component Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> Co-authored-by: Philipp Pracht <philipp.pracht@sap.com> Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
stanleychh
added a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* First commit for wc * Adding example for WC * Adding Web Component Documentation * Doc changes * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update client-frameworks-support/client-support-angular/projects/client-support-angular/src/lib/route/luigi-activated-route-snapshot-helper.ts * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Fixing error in luigi core doc * Adding nv documentation * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Adding doc images * Update docs/luigi-core-api.md Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> * Removed unused file * Rename component title * removed white spaces * Adding clazz name to fiddle example, removign examples in the documentation * adding new fiddle component * Adding UI5 Component * Changing label UI5 components * Custom mf for user settings (SAP#1802) * Rewrite getting started guide (SAP#1766) * state-store fix (SAP#1814) Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com> * ng support lib enhancements (SAP#1809) Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> * 1767 different visual appearances (SAP#1790) * Profile setting dialog (SAP#1710) * Read/write settings using core api (SAP#1709) * Dialog box for user settings (SAP#1750) known issue.. grid is not displayed correctly in ie11 * Adding new configuration for enum displayed as buttons * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Changing testdataid with id in html attribute * Adding again testid * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * changing button to segment and group.... * Fixing integration tests Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * merging and resolving conflics * adding new fiddle component * Adding UI5 Component Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> Co-authored-by: Philipp Pracht <philipp.pracht@sap.com> Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #1743