Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Different Visual Appearances for Enums #1790

Merged
merged 21 commits into from
Jan 19, 2021
Merged

Add Different Visual Appearances for Enums #1790

merged 21 commits into from
Jan 19, 2021

Conversation

legteodav
Copy link
Contributor

@legteodav legteodav commented Dec 17, 2020 •
edited by ndricimrr
Loading

Related issue(s)
Resolves #1767

JohannesDoberer and others added 8 commits November 25, 2020 11:51
@JohannesDoberer
Profile setting dialog (SAP#1710)
adff27d
@JohannesDoberer
Merge branch 'master' into feature-user-settings
98d9f73 
* master:
  add blog post (SAP#1731)
  Release v1.6.0 (SAP#1729)
  cm fix (SAP#1727)
  Added state info to replacestate (SAP#1725)
  Simple storage api for micro frontends#1696 (SAP#1707)
  Fix broken angular link (SAP#1717)
  Fix css issue for Iframe (SAP#1716)
@JohannesDoberer
Read/write settings using core api (SAP#1709)
f13522f
@JohannesDoberer
Merge branch 'master' into feature-user-settings
b2f4026 
* master:
  update luigi in fiddle
  Change Search using Luigi.globalSearch() API (SAP#1690) (SAP#1734)
  Fix `withoutSync()` history behaviour (SAP#1720)
  Update index.scss
  Bump highlight.js in /core/examples/luigi-example-vue (SAP#1723)
@JohannesDoberer
Merge branch 'master' into feature-user-settings
fb7d89f 
* master:
  release-v1.7.0 (SAP#1759)
  CM fixes (SAP#1755)
  changes for night build (SAP#1757)
  Feature angular supporting library (SAP#1756)
  Website security (SAP#1742)
  fixed case sensitivity issue in luigi element
  Feature wc support (SAP#1751)
@JohannesDoberer
Dialog box for user settings (SAP#1750)
f653bb0 
known issue.. grid is not displayed correctly in ie11
@JohannesDoberer
Merge branch 'master' into feature-user-settings
c3c5f1f 
* master:
  Bump ini from 1.3.5 to 1.3.8 in /scripts (SAP#1783)
  Bump ini from 1.3.5 to 1.3.8 in /website/docs (SAP#1780)
  Bump ini from 1.3.5 to 1.3.7 in /client (SAP#1774)
  Bump ini from 1.3.5 to 1.3.7 in /core (SAP#1775)
  replace insensitive term (SAP#1771)
@legteodav
Adding new configuration for enum displayed as buttons
768971b
@legteodav
Merge remote-tracking branch 'SAP/master' into 1767-different-visual-…
8a1bd2d 
…appearances
@legteodav
Merge remote-tracking branch 'SAP/master' into 1767-different-visual-…
9504155 
…appearances

# Conflicts:
#	core/package.json
#	core/src/App.html
#	core/src/UserSettingsEditor.html
#	core/src/core-api/config.js
#	test/e2e-test-application/src/luigi-config/extended/settings.js
@legteodav legteodav linked an issue Dec 17, 2020 that may be closed by this pull request
Different visual appearances for enums #1767
Closed
@JohannesDoberer JohannesDoberer added this to the Sprint 15 milestone Dec 18, 2020
@stanleychh stanleychh self-assigned this Dec 18, 2020
stanleychh
stanleychh suggested changes Dec 18, 2020
View reviewed changes
core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
@legteodav @stanleychh
Update core/src/UserSettingsEditor.html
d2ee9a1 
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
@JohannesDoberer JohannesDoberer self-assigned this Dec 22, 2020
stanleychh
stanleychh reviewed Jan 11, 2021
View reviewed changes
core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
core/src/UserSettingsEditor.html Outdated Show resolved Hide resolved
JohannesDoberer and others added 4 commits January 11, 2021 15:17
@JohannesDoberer
Merge branch 'master' into 1767-different-visual-appearances
7bf5a1d
@legteodav @stanleychh
Update core/src/UserSettingsEditor.html
a223e0d 
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
@legteodav @stanleychh
Update core/src/UserSettingsEditor.html
2a0f923 
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
@legteodav @stanleychh
Update core/src/UserSettingsEditor.html
3a5c139 
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
@legteodav @stanleychh
Update core/src/UserSettingsEditor.html
ed29577 
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
JohannesDoberer
JohannesDoberer approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good Job 👍

@legteodav legteodav merged commit b2b23ec into SAP:master Jan 19, 2021
legteodav added a commit to legteodav/luigi that referenced this pull request Jan 19, 2021
@legteodav @JohannesDoberer @stanleychh
1767 different visual appearances (SAP#1790)
0b3d7fb 
* Profile setting dialog (SAP#1710)

* Read/write settings using core api (SAP#1709)

* Dialog box for user settings (SAP#1750)

known issue.. grid is not displayed correctly in ie11

* Adding new configuration for enum displayed as buttons

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Changing testdataid with id in html attribute

* Adding again testid

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* changing button to segment and group....

* Fixing integration tests

Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
legteodav added a commit that referenced this pull request Jan 19, 2021
@legteodav @ndricimrr
@UlianaMunich @JohannesDoberer @alexandra-simeonova @hardl @stanleychh
Add fiddle example and docu for web components (#1795)
1fd217d 
* First commit for wc

* Adding example for WC

* Adding Web Component Documentation

* Doc changes

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update client-frameworks-support/client-support-angular/projects/client-support-angular/src/lib/route/luigi-activated-route-snapshot-helper.ts

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Fixing error in luigi core doc

* Adding nv documentation

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Adding doc images

* Update docs/luigi-core-api.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>

* Removed unused file

* Rename component title

* removed white spaces

* Adding clazz name to fiddle example, removign examples in the documentation

* adding new fiddle component

* Adding UI5 Component

* Changing label UI5 components

* Custom mf for user settings (#1802)

* Rewrite getting started guide (#1766)

* state-store fix (#1814)

Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com>

* ng support lib enhancements (#1809)

Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>

* 1767 different visual appearances (#1790)

* Profile setting dialog (#1710)

* Read/write settings using core api (#1709)

* Dialog box for user settings (#1750)

known issue.. grid is not displayed correctly in ie11

* Adding new configuration for enum displayed as buttons

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Changing testdataid with id in html attribute

* Adding again testid

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* changing button to segment and group....

* Fixing integration tests

Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* merging and resolving conflics

* adding new fiddle component

* Adding UI5 Component

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>
Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Philipp Pracht <philipp.pracht@sap.com>
Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com>
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
@ndricimrr ndricimrr added the enhancement New feature or request label Jan 21, 2021
@ndricimrr ndricimrr changed the title 1767 different visual appearances Add Different Visual Appearances for Enums Jan 21, 2021
@ndricimrr ndricimrr mentioned this pull request Jan 21, 2021
Merged
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@legteodav @JohannesDoberer @stanleychh
1767 different visual appearances (SAP#1790)
7c2cbc7 
* Profile setting dialog (SAP#1710)

* Read/write settings using core api (SAP#1709)

* Dialog box for user settings (SAP#1750)

known issue.. grid is not displayed correctly in ie11

* Adding new configuration for enum displayed as buttons

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Changing testdataid with id in html attribute

* Adding again testid

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* changing button to segment and group....

* Fixing integration tests

Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@legteodav @ndricimrr
@UlianaMunich @JohannesDoberer @alexandra-simeonova @hardl @stanleychh
Add fiddle example and docu for web components (SAP#1795)
6ff2858 
* First commit for wc

* Adding example for WC

* Adding Web Component Documentation

* Doc changes

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update client-frameworks-support/client-support-angular/projects/client-support-angular/src/lib/route/luigi-activated-route-snapshot-helper.ts

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Fixing error in luigi core doc

* Adding nv documentation

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

* Adding doc images

* Update docs/luigi-core-api.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>

* Removed unused file

* Rename component title

* removed white spaces

* Adding clazz name to fiddle example, removign examples in the documentation

* adding new fiddle component

* Adding UI5 Component

* Changing label UI5 components

* Custom mf for user settings (SAP#1802)

* Rewrite getting started guide (SAP#1766)

* state-store fix (SAP#1814)

Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com>

* ng support lib enhancements (SAP#1809)

Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>

* 1767 different visual appearances (SAP#1790)

* Profile setting dialog (SAP#1710)

* Read/write settings using core api (SAP#1709)

* Dialog box for user settings (SAP#1750)

known issue.. grid is not displayed correctly in ie11

* Adding new configuration for enum displayed as buttons

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Changing testdataid with id in html attribute

* Adding again testid

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* changing button to segment and group....

* Fixing integration tests

Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>

* merging and resolving conflics

* adding new fiddle component

* Adding UI5 Component

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>
Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Philipp Pracht <philipp.pracht@sap.com>
Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com>
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleychh stanleychh stanleychh approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees

@stanleychh stanleychh

@JohannesDoberer JohannesDoberer

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 15
Development

Successfully merging this pull request may close these issues.

Different visual appearances for enums
4 participants
@legteodav @stanleychh @JohannesDoberer @ndricimrr