-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animate multicolumn #2409
Animate multicolumn #2409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great in my testing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Monica! I noticed 1 thing:
- The mobile slide/fade in is different from larger screens. Notice the shadow or shape being cut out at the bottom as it reveals in place.
16-35-aede6-1hep8.mp4
2c6692e
to
e571ff5
Compare
b4c2dc1
to
f832fc8
Compare
b1d30d8
to
dc520d9
Compare
@melissaperreault we've made some changes to the animation since then and the product cards also fade in now, so I don't think this will be a problem anymore. We also decided to disable the cascading effect on carousels, for now. Here's a slow-motion video. Let me know if you're still noticing any issues. shadow-slow.mp4 |
* add animation to Image banner and Image with text
* add animation to Image banner and Image with text
c3082cc
to
a6ed84f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Monica!
Tiny refinement detail that we can leave for a follow up if we feel this is a final polish alignment to keep close eye on.
- As we reveal similar sections, the relationship of the animation between the section Title and the Cards is different from Featured collection section and Multicolumn section. The first one will reveal the title sooner than the Multicolumn one (Video example)
@melissaperreault this is a valid point, but it's something we should fix as part of another issue. It only happens when the previous section is a Featured collection, and thus has more to do with refining that section rather than this one (see video below). cascading.mp4I think the delay is caused by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome Monica, thanks! Let's open an issue to follow up on your recommendation! 🎉
* shopify/main: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480)
* next: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480) Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next
add cascading animation to multicolumn
PR Summary:
Adds cascading fade in on scroll animation to Multicolumn section.
Why are these changes introduced?
Fixes #2382
What approach did you take?
Replicated animations from the original prototype
Visual impact on existing themes
Will animate Multicolumn section on scroll, when
Reveal sections on scroll
is enabledmulticolumn.mp4
Testing steps/scenarios
Reveal sections on scroll
underAnimations
in Theme settingsDemo links
Checklist