Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate multicolumn #2409

Merged
merged 13 commits into from
Apr 4, 2023
Merged

Animate multicolumn #2409

merged 13 commits into from
Apr 4, 2023

Conversation

metamoni
Copy link
Contributor

@metamoni metamoni commented Mar 15, 2023

PR Summary:

Adds cascading fade in on scroll animation to Multicolumn section.

Why are these changes introduced?

Fixes #2382

What approach did you take?

Replicated animations from the original prototype

Visual impact on existing themes

Will animate Multicolumn section on scroll, when Reveal sections on scroll is enabled

multicolumn.mp4

Testing steps/scenarios

  • Enable Reveal sections on scroll under Animations in Theme settings
  • On the home page, add a Multicolumn section and verify that it fades in on scroll
  • Verify that each column cascades in
  • Update the section's settings and verify that everything still works as expected

Demo links

Checklist

@metamoni metamoni changed the base branch from main to animate-featured-collection March 15, 2023 18:05
@metamoni metamoni marked this pull request as ready for review March 15, 2023 18:17
@metamoni metamoni self-assigned this Mar 15, 2023
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great in my testing!

@kjellr kjellr mentioned this pull request Mar 15, 2023
11 tasks
Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Monica! I noticed 1 thing:

  • The mobile slide/fade in is different from larger screens. Notice the shadow or shape being cut out at the bottom as it reveals in place.
16-35-aede6-1hep8.mp4

@metamoni metamoni force-pushed the animate-featured-collection branch 11 times, most recently from 2c6692e to e571ff5 Compare March 23, 2023 10:10
@metamoni metamoni force-pushed the animate-featured-collection branch 6 times, most recently from b4c2dc1 to f832fc8 Compare March 29, 2023 14:38
@metamoni metamoni force-pushed the animate-multicolumn branch 3 times, most recently from b1d30d8 to dc520d9 Compare March 29, 2023 15:20
@metamoni
Copy link
Contributor Author

@melissaperreault we've made some changes to the animation since then and the product cards also fade in now, so I don't think this will be a problem anymore. We also decided to disable the cascading effect on carousels, for now. Here's a slow-motion video. Let me know if you're still noticing any issues.

shadow-slow.mp4

Copy link
Contributor

@LucasLacerdaUX LucasLacerdaUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Monica!

Tiny refinement detail that we can leave for a follow up if we feel this is a final polish alignment to keep close eye on.

  • As we reveal similar sections, the relationship of the animation between the section Title and the Cards is different from Featured collection section and Multicolumn section. The first one will reveal the title sooner than the Multicolumn one (Video example)

@metamoni
Copy link
Contributor Author

metamoni commented Apr 4, 2023

  • As we reveal similar sections, the relationship of the animation between the section Title and the Cards is difference from Featured collection section and Multicolumn section. The first one will reveal the title sooner than the Multicolumn one (Video example)

@melissaperreault this is a valid point, but it's something we should fix as part of another issue. It only happens when the previous section is a Featured collection, and thus has more to do with refining that section rather than this one (see video below).

cascading.mp4

I think the delay is caused by the data-cascade attribute on the Featured collection, which enables the cascading animation. For this to work properly we'd have to remove that attribute when it's not necessary, which we're not currently doing because we'd have to know whether we're in mobile/desktop view.

Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Monica, thanks! Let's open an issue to follow up on your recommendation! 🎉

@metamoni metamoni merged commit fdcd182 into main Apr 4, 2023
@metamoni metamoni deleted the animate-multicolumn branch April 4, 2023 14:04
pangloss added a commit to pangloss/dawn that referenced this pull request Apr 5, 2023
* shopify/main:
  [Video] Add fade in on scroll animation (Shopify#2495)
  Animate rich text and email signup (Shopify#2408)
  [Gift card] Add help doc link and change label for translation (Shopify#2471)
  Add prettier config to support format-on-save (Shopify#2323)
  Announcements slideshow (Shopify#2394)
  fix: Update Follow on Shop Option Text (Shopify#2463)
  Enable "per-PR" async PR mode (Shopify#2488)
  Animate multicolumn (Shopify#2409)
  Fix improper image sizes in the collage section (Shopify#2478)
  Replaced depreciated liquid property/value (Shopify#2480)
pangloss added a commit to pangloss/dawn that referenced this pull request Apr 12, 2023
* next:
  [Video] Add fade in on scroll animation (Shopify#2495)
  Animate rich text and email signup (Shopify#2408)
  [Gift card] Add help doc link and change label for translation (Shopify#2471)
  Add prettier config to support format-on-save (Shopify#2323)
  Announcements slideshow (Shopify#2394)
  fix: Update Follow on Shop Option Text (Shopify#2463)
  Enable "per-PR" async PR mode (Shopify#2488)
  Animate multicolumn (Shopify#2409)
  Fix improper image sizes in the collage section (Shopify#2478)
  Replaced depreciated liquid property/value (Shopify#2480)
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
add cascading animation to multicolumn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multicolumn] Add cascading fade in on scroll animation
5 participants