[Gift card] Add help doc link and change label for translation #2471

ludoboludo · 2023-03-27T19:55:03Z

PR Summary:

This is to add a link to the help docs in the editor. So that if the merchant needs more info about how to add a gift card product, it's easy to get to.
It also changes a label so that if they're editing their language file, the label is a bit clearer.

Why are these changes introduced?

Solves a couple issues mentioned in #2454

What approach did you take?

Linked to the help doc explaining how to add a gift card product.

Other considerations

Decision log

#	Decision	Alternatives	Rationale	Downsides
1

Visual impact on existing themes

No visual impact on the theme. Just some added context to the editor.

Testing steps/scenarios

Make sure everything about gift card works as expected. Go to a product page, edit the buy buttons block and enable the gift card feature.
Go to a gift card product and make sure everything is working. When clicking the checkbox it will show a form.

Demo links

Editor

Checklist

Added PR summary for release notes
Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
Created a ticket for the help.shopify.com documentation team about updates to theme settings. (Internal-only task)
Followed theme code principles
Linted with Theme Check
Tested on mobile
Tested on multiple browsers
Tested for accessibility

ludoboludo · 2023-03-27T19:59:48Z

locales/en.default.schema.json

@@ -866,7 +866,7 @@
            },
            "show_gift_card_recipient": {
              "label": "Show recipient form for gift card products",
-              "info": "When enabled, gift card products can optionally be sent to a recipient with a personal message."
+              "info": "When enabled, gift card products can optionally be sent to a recipient with a personal message.[Learn more](https://help.shopify.com/en/manual/products/gift-card-products/add-update-gift-card-products)"


This is for the featured product section but the setting isn't present on that section. So not sure if we should remove it or leave it there for when it's added in the future 🤔 cc: @antiBaconMachine

If we know for sure it's getting added I feel like it's probably fine to leave in, but I would also say I wouldn't mind just repurposing the main-product entries in featured-product instead of duplicating them here. We've started doing that more.

kmeleta · 2023-03-29T15:29:24Z

locales/en.default.json

@@ -459,7 +459,7 @@
    "form": {
      "checkbox": "I want to send this as a gift",
      "email_label": "Recipient email",
-      "email_label_optional": "Recipient email (optional)",
+      "email_label_optional_for_no_js_behavior": "Recipient email (optional)",


Little wordy no?

Suggested change

"email_label_optional_for_no_js_behavior": "Recipient email (optional)",

"email_label_no_js": "Recipient email (optional)",

yeah but that's what is turned into the wording in the admin 😬
So I wasn't sure if Email label no js was clear enough for non technical folks. Not that Email label optional for no js behaviour is much clearer but if you're looking for that means on the internet, it seems maybe easier 🤷

What do you think?

I'd probably rather it be more concise, but it's not a hill I'll die on by any stretch, so if you think this is better that's fine with me.

Honestly, I'm not even sure it would be wrong to just use email_label_optional either. That's probably more inline with standard procedure, but I could see that being perceived as a mistake too.

I feel like it's fine to keep it wordy in json files because I think it's better to be more descriptive there rather than compact.

email_label_optional is confusing/vague for a merchant I think.
Here is the current look of it:

Screenshot

There are more opportunities to make it clearer. Name and Message can be confusing as well. They're used as placeholders which is only picked up when using a screen reader:

Screenshot

Sorry I should have followed this back to the line item in the issue. I understand where you're coming from now. I'm fine with what you had originally 👍

kmeleta · 2023-03-29T15:32:21Z

locales/en.default.schema.json

@@ -866,7 +866,7 @@
            },
            "show_gift_card_recipient": {
              "label": "Show recipient form for gift card products",
-              "info": "When enabled, gift card products can optionally be sent to a recipient with a personal message."
+              "info": "When enabled, gift card products can optionally be sent to a recipient with a personal message.[Learn more](https://help.shopify.com/en/manual/products/gift-card-products/add-update-gift-card-products)"


If we know for sure it's getting added I feel like it's probably fine to leave in, but I would also say I wouldn't mind just repurposing the main-product entries in featured-product instead of duplicating them here. We've started doing that more.

eugenekasimov

Looks good. Let's wait for translations.

kmeleta · 2023-04-04T14:19:52Z

assets/section-main-product.css

@@ -1502,6 +1502,7 @@ a.product__text {
  align-items: flex-start;
  max-width: inherit;
  position: relative;
+  cursor: pointer;


Thanks for adding this

kmeleta · 2023-04-04T14:29:40Z

locales/en.default.schema.json

-            "show_gift_card_recipient": {
-              "label": "Show recipient form for gift card products",
-              "info": "When enabled, gift card products can optionally be sent to a recipient with a personal message."


Noticed this wording was actually a little different from the main product entry anyway (and it probably shouldn't have been).

ludoboludo · 2023-04-04T15:03:26Z

FYI, I just had to replace the actual link I was using. A new doc was shipped by the gift card team and the link I had before was passing in the language when it shouldn't:
before

https://help.shopify.com/en/manual/products/gift-card-products/add-update-gift-card-products)

after

https://help.shopify.com/manual/online-store/themes/customizing-themes/add-gift-card-recipient-fields

* shopify/main: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480)

* next: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480) Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next

…fy#2471)

Add help doc link and change label for translation

caa57bc

ludoboludo commented Mar 27, 2023

View reviewed changes

eugenekasimov self-requested a review March 27, 2023 20:26

kmeleta reviewed Mar 29, 2023

View reviewed changes

remove unused translation string and add CSS for cursor's pointer

f208a30

eugenekasimov reviewed Mar 29, 2023

View reviewed changes

translation-platform bot added 6 commits March 31, 2023 15:11

Update 20 translation files

d631b91

Update 6 translation files

abb7abc

Update 17 translation files

b735912

Update 3 translation files

4d436b9

Update 1 translation file

54fd939

Update 3 translation files

637e32d

ludoboludo requested review from kmeleta and eugenekasimov April 4, 2023 14:12

kmeleta approved these changes Apr 4, 2023

View reviewed changes

eugenekasimov approved these changes Apr 4, 2023

View reviewed changes

replace hardcoded english link

5559d06

ludoboludo merged commit b8bfb79 into main Apr 4, 2023

ludoboludo deleted the gift-card-follow-ups branch April 4, 2023 17:44

phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024

[Gift card] Add help doc link and change label for translation (Shopi…

9f973a8

…fy#2471)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gift card] Add help doc link and change label for translation #2471

[Gift card] Add help doc link and change label for translation #2471

ludoboludo commented Mar 27, 2023

ludoboludo Mar 27, 2023

kmeleta Mar 29, 2023 •

edited

Loading

kmeleta Mar 29, 2023

ludoboludo Mar 29, 2023

kmeleta Mar 29, 2023

eugenekasimov Mar 29, 2023

ludoboludo Mar 30, 2023

kmeleta Mar 30, 2023

kmeleta Mar 29, 2023 •

edited

Loading

eugenekasimov left a comment

kmeleta Apr 4, 2023

kmeleta Apr 4, 2023

ludoboludo commented Apr 4, 2023

	"email_label_optional_for_no_js_behavior": "Recipient email (optional)",
	"email_label_no_js": "Recipient email (optional)",

[Gift card] Add help doc link and change label for translation #2471

[Gift card] Add help doc link and change label for translation #2471

Conversation

ludoboludo commented Mar 27, 2023

PR Summary:

Why are these changes introduced?

What approach did you take?

Other considerations

Decision log

Visual impact on existing themes

Testing steps/scenarios

Demo links

Checklist

Choose a reason for hiding this comment

kmeleta Mar 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kmeleta Mar 29, 2023 • edited Loading

Choose a reason for hiding this comment

eugenekasimov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ludoboludo commented Apr 4, 2023

kmeleta Mar 29, 2023 •

edited

Loading

kmeleta Mar 29, 2023 •

edited

Loading