[Video] Add fade in on scroll animation #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
requested review from
stufreen,
metamoni,
melissaperreault and
ludoboludo
metamoni
approved these changes
Apr 5, 2023
melissaperreault
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Thanks Kjell! That's a quick one!
Initially I was going to raise that we could make the Video section similar to Image banner but since we'll adjust the animation above the fold with https://github.com/Shopify/themes/issues/400, I am less concerned of the potential jarring experience in the end if it's used as the hero section.
Works as expected! 🚢
ludoboludo
approved these changes
Apr 5, 2023
|
Thanks everyone! |
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Apr 5, 2023
* shopify/main: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480)
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Apr 12, 2023
* next: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480) Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Why are these changes introduced?
Closes #2423
What approach did you take?
Replicated animations from the original prototype
Visual impact on existing themes
Will animate Multicolumn section on scroll, when Reveal sections on scroll is enabled.
05-23-ha3v4-bfr0t.mp4
Testing steps/scenarios
Demo links
Checklist