-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: perf improvements for amalthea sessions #411
Merged
olevski
merged 7 commits into
release-amaltheas-migration
from
feat-performance-improvements-new-notebooks
Oct 1, 2024
Merged
feat: perf improvements for amalthea sessions #411
olevski
merged 7 commits into
release-amaltheas-migration
from
feat-performance-improvements-new-notebooks
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack: Change managed by git-spice. |
This was referenced Sep 17, 2024
olevski
had a problem deploying
to
renku-ci-ds-411
September 17, 2024 15:30
— with
GitHub Actions
Failure
You can access the deployment of this PR at https://renku-ci-ds-411.dev.renku.ch |
olevski
temporarily deployed
to
renku-ci-ds-411
September 17, 2024 15:47
— with
GitHub Actions
Inactive
olevski
force-pushed
the
feat-performance-improvements-new-notebooks
branch
from
September 17, 2024 16:18
914e29b
to
a313341
Compare
olevski
temporarily deployed
to
renku-ci-ds-411
September 17, 2024 16:18
— with
GitHub Actions
Inactive
olevski
temporarily deployed
to
renku-ci-ds-411
September 18, 2024 12:42
— with
GitHub Actions
Inactive
olevski
temporarily deployed
to
renku-ci-ds-411
September 18, 2024 13:47
— with
GitHub Actions
Inactive
olevski
temporarily deployed
to
renku-ci-ds-411
September 19, 2024 11:27
— with
GitHub Actions
Inactive
olevski
force-pushed
the
feat-add-cloudstorage
branch
4 times, most recently
from
September 23, 2024 13:28
66abee9
to
ae8096f
Compare
olevski
force-pushed
the
feat-performance-improvements-new-notebooks
branch
from
September 23, 2024 14:40
a313341
to
ad13544
Compare
olevski
force-pushed
the
feat-add-cloudstorage
branch
3 times, most recently
from
September 23, 2024 14:57
806ea04
to
a4d2e26
Compare
olevski
force-pushed
the
feat-performance-improvements-new-notebooks
branch
from
September 23, 2024 15:00
ad13544
to
8a998d4
Compare
olevski
temporarily deployed
to
renku-ci-ds-411
September 23, 2024 15:01
— with
GitHub Actions
Inactive
olevski
force-pushed
the
feat-performance-improvements-new-notebooks
branch
from
September 23, 2024 15:49
8a998d4
to
6f991fc
Compare
olevski
temporarily deployed
to
renku-ci-ds-411
September 23, 2024 15:49
— with
GitHub Actions
Inactive
olevski
force-pushed
the
feat-performance-improvements-new-notebooks
branch
from
September 23, 2024 16:00
6f991fc
to
3b92186
Compare
olevski
temporarily deployed
to
renku-ci-ds-411
September 23, 2024 16:00
— with
GitHub Actions
Inactive
olevski
force-pushed
the
feat-add-cloudstorage
branch
2 times, most recently
from
September 27, 2024 13:03
bf8efeb
to
04553ec
Compare
This only removes the large class from the new sessions endpoints that talk to the new amalthea.
olevski
force-pushed
the
feat-performance-improvements-new-notebooks
branch
from
September 27, 2024 14:21
3b92186
to
96a787a
Compare
olevski
temporarily deployed
to
renku-ci-ds-411
September 27, 2024 14:21
— with
GitHub Actions
Inactive
m-alisafaee
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tasko! I've made some minor comments.
components/renku_data_services/notebooks/api/amalthea_patches/init_containers.py
Outdated
Show resolved
Hide resolved
components/renku_data_services/notebooks/api/amalthea_patches/git_proxy.py
Outdated
Show resolved
Hide resolved
components/renku_data_services/notebooks/api/amalthea_patches/init_containers.py
Outdated
Show resolved
Hide resolved
m-alisafaee
approved these changes
Sep 30, 2024
Tearing down the temporary RenkuLab deplyoment for this PR. |
olevski
added a commit
that referenced
this pull request
Oct 2, 2024
olevski
added a commit
that referenced
this pull request
Oct 4, 2024
olevski
added a commit
that referenced
this pull request
Oct 4, 2024
olevski
added a commit
that referenced
this pull request
Oct 4, 2024
olevski
added a commit
that referenced
this pull request
Oct 8, 2024
olevski
added a commit
that referenced
this pull request
Oct 22, 2024
olevski
added a commit
that referenced
this pull request
Oct 28, 2024
olevski
added a commit
that referenced
this pull request
Oct 30, 2024
olevski
added a commit
that referenced
this pull request
Oct 31, 2024
olevski
added a commit
that referenced
this pull request
Nov 1, 2024
olevski
added a commit
that referenced
this pull request
Nov 4, 2024
olevski
added a commit
that referenced
this pull request
Nov 6, 2024
olevski
added a commit
that referenced
this pull request
Nov 8, 2024
olevski
added a commit
that referenced
this pull request
Nov 11, 2024
olevski
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/deploy renku=feat-jupyter-free-sessions amalthea-sessions=feat-add-cloud-storage renku-notebooks=feat-add-amalthea-session-cache renku-gateway=feat-add-renku-refresh-token-for-data-service renku-ui=andrea/use-data-service-sessions-2.0 extra-values=amalthea-sessions.deployCrd=false #notest