feat!: expand environments specification #338

olevski · 2024-08-02T13:28:59Z

This is a breaking change of the session launchers endpoints.

/deploy renku-ui=andrea/custom-launcher-jupyter-free

olevski · 2024-08-02T15:14:07Z

This change is part of the following stack:

feat: add new apispec for the new amalthea sessions #360
- feat!: expand environments specification #338 ◀
  - refactor: add validation to storage, repo and session blueprints #347

_{Change managed by git-spice.}

coveralls · 2024-08-02T15:14:13Z

Pull Request Test Coverage Report for Build 10353957042

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

227 of 237 (95.78%) changed or added relevant lines in 7 files are covered.
48 unchanged lines in 9 files lost coverage.
Overall coverage increased (+0.4%) to 90.758%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
components/renku_data_services/session/apispec_base.py	7	8	87.5%
components/renku_data_services/session/models.py	50	54	92.59%
components/renku_data_services/session/db.py	59	64	92.19%

Files with Coverage Reduction	New Missed Lines	%
components/renku_data_services/connected_services/blueprints.py	1	99.07%
components/renku_data_services/crc/db.py	1	87.81%
components/renku_data_services/session/db.py	1	92.27%
components/renku_data_services/storage/blueprints.py	2	94.65%
components/renku_data_services/users/blueprints.py	3	97.93%
components/renku_data_services/base_models/validation.py	4	78.95%
components/renku_data_services/secrets/db.py	6	93.07%
components/renku_data_services/secrets/core.py	10	80.26%
components/renku_data_services/crc/blueprints.py	20	93.19%

Totals
Change from base Build 10285141847:	0.4%
Covered Lines:	9202
Relevant Lines:	10139

💛 - Coveralls

components/renku_data_services/session/apispec.py

Panaetius · 2024-08-12T10:41:37Z

components/renku_data_services/session/api.spec.yaml

+        - GLOBAL
+        - CUSTOM
+      example: CUSTOM


question: this is a breaking change in the API, does the UI already deal with this/know about this?

They do know and that is why we cannot merge this. Andrea is working on adapting the ui to these changes.

components/renku_data_services/session/db.py

components/renku_data_services/session/models.py

RenkuBot · 2024-08-12T13:47:35Z

You can access the deployment of this PR at https://renku-ci-ds-338.dev.renku.ch

olevski · 2024-08-27T13:53:20Z

This change is part of the following stack:

feat!: expand environments specification #338 ◀
- feat: run notebooks in data service #375
  - feat: use cloud storage from amalthea #387
    - feat: perf improvements for amalthea sessions #411

_{Change managed by git-spice.}

chore: filter environments by owner type squashme: address comments feat!: expand environment specification This is a breaking change in the API. chore: add tests and minor fixes chore: test the global environments migration chore: fix tests chore: minor improvements to db session handling squashme: minor fix squashme: fixups for conflict resolutuion after merge squashme: fix failing tests chore: address comments

RenkuBot · 2024-09-20T14:14:19Z

Tearing down the temporary RenkuLab deplyoment for this PR.

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski requested a review from a team as a code owner August 2, 2024 13:29

olevski changed the title ~~feat: expand environments specification~~ feat!: expand environments specification Aug 2, 2024

Panaetius requested changes Aug 12, 2024

View reviewed changes

olevski temporarily deployed to renku-ci-ds-338 August 12, 2024 13:46 — with GitHub Actions Inactive

olevski temporarily deployed to renku-ci-ds-338 August 12, 2024 14:35 — with GitHub Actions Inactive

olevski temporarily deployed to renku-ci-ds-338 August 20, 2024 13:54 — with GitHub Actions Inactive

olevski changed the base branch from main to feat-add-new-sessions-apispec August 27, 2024 13:26

olevski had a problem deploying to renku-ci-ds-338 August 27, 2024 13:33 — with GitHub Actions Failure

This was referenced Aug 27, 2024

feat: add new apispec for the new amalthea sessions #360

Merged

feat: launch sessions using the new operator #351

Closed

olevski had a problem deploying to renku-ci-ds-338 August 27, 2024 14:14 — with GitHub Actions Failure

olevski force-pushed the feat-add-new-sessions-apispec branch from 5a4dfa2 to a4f95d8 Compare August 27, 2024 19:22

olevski force-pushed the feat-expand-environments-specification branch from 1e99745 to 5e6c418 Compare August 27, 2024 19:31

olevski had a problem deploying to renku-ci-ds-338 August 27, 2024 19:31 — with GitHub Actions Failure

olevski force-pushed the feat-expand-environments-specification branch from 5e6c418 to dedee10 Compare August 27, 2024 21:03

olevski temporarily deployed to renku-ci-ds-338 August 27, 2024 21:03 — with GitHub Actions Inactive

olevski had a problem deploying to renku-ci-ds-338 August 27, 2024 21:17 — with GitHub Actions Error

olevski force-pushed the feat-expand-environments-specification branch from 5381766 to 8872560 Compare August 27, 2024 21:21

olevski temporarily deployed to renku-ci-ds-338 August 27, 2024 21:21 — with GitHub Actions Inactive

olevski force-pushed the feat-expand-environments-specification branch from 8872560 to 4eb2c24 Compare August 27, 2024 21:32

olevski temporarily deployed to renku-ci-ds-338 August 27, 2024 21:33 — with GitHub Actions Inactive

olevski mentioned this pull request Aug 27, 2024

feat: run notebooks in data service #375

Merged

olevski force-pushed the feat-add-new-sessions-apispec branch from a4f95d8 to 3da7dc0 Compare August 28, 2024 09:26

olevski force-pushed the feat-expand-environments-specification branch from 4eb2c24 to d76ef5e Compare August 28, 2024 11:30

olevski temporarily deployed to renku-ci-ds-338 August 28, 2024 11:30 — with GitHub Actions Inactive

olevski force-pushed the feat-expand-environments-specification branch from d76ef5e to 03223a7 Compare August 28, 2024 11:58

olevski added 4 commits September 20, 2024 13:17

feat: add command and args to environments

ce335d2

chore: use PurePosixPath type in sqlalchemy

70dee1a

squashme: cleanup session launcher updates

1e21119

olevski force-pushed the feat-expand-environments-specification branch from 06a89bf to 1e21119 Compare September 20, 2024 11:17

olevski temporarily deployed to renku-ci-ds-338 September 20, 2024 11:18 — with GitHub Actions Inactive

squashme: fix failing test

ff60521

olevski deployed to renku-ci-ds-338 September 20, 2024 13:27 — with GitHub Actions View deployment

Panaetius approved these changes Sep 20, 2024

View reviewed changes

olevski merged commit 6cb133f into release-amaltheas-migration Sep 20, 2024
12 of 16 checks passed

olevski deleted the feat-expand-environments-specification branch September 20, 2024 14:13

olevski added a commit that referenced this pull request Sep 20, 2024

feat!: expand environments specification (#338)

b67440b

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Sep 23, 2024

feat!: expand environments specification (#338)

99e2296

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Sep 25, 2024

feat!: expand environments specification (#338)

934c4d2

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Oct 2, 2024

feat!: expand environments specification (#338)

52710cd

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Oct 4, 2024

feat!: expand environments specification (#338)

bfccada

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski mentioned this pull request Oct 4, 2024

[REBASE only]: Migrate notebooks and add new amalthea #418

Merged

olevski added a commit that referenced this pull request Oct 8, 2024

feat!: expand environments specification (#338)

b21576a

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski mentioned this pull request Oct 17, 2024

feat: update and expand apispec for environments #300

Closed

olevski added a commit that referenced this pull request Oct 22, 2024

feat!: expand environments specification (#338)

f9805cd

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Oct 28, 2024

feat!: expand environments specification (#338)

0c1e0e8

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Oct 30, 2024

feat!: expand environments specification (#338)

0aec28d

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Oct 31, 2024

feat!: expand environments specification (#338)

6a6bab9

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Nov 1, 2024

feat!: expand environments specification (#338)

13d373f

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Nov 4, 2024

feat!: expand environments specification (#338)

a747553

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Nov 6, 2024

feat!: expand environments specification (#338)

71972eb

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Nov 8, 2024

feat!: expand environments specification (#338)

fcba696

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Nov 11, 2024

feat!: expand environments specification (#338)

a6e8243

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

olevski added a commit that referenced this pull request Nov 11, 2024

feat!: expand environments specification (#338)

0526669

This is a breaking change in the API. It requires changes in the UI for it to be fully useful.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: expand environments specification #338

feat!: expand environments specification #338

olevski commented Aug 2, 2024 •

edited

Loading

olevski commented Aug 2, 2024 •

edited by Panaetius

Loading

coveralls commented Aug 2, 2024 •

edited

Loading

Panaetius Aug 12, 2024

olevski Aug 12, 2024

RenkuBot commented Aug 12, 2024

olevski commented Aug 27, 2024 •

edited

Loading

RenkuBot commented Sep 20, 2024

feat!: expand environments specification #338

feat!: expand environments specification #338

Conversation

olevski commented Aug 2, 2024 • edited Loading

olevski commented Aug 2, 2024 • edited by Panaetius Loading

coveralls commented Aug 2, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10353957042

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Panaetius Aug 12, 2024

Choose a reason for hiding this comment

olevski Aug 12, 2024

Choose a reason for hiding this comment

RenkuBot commented Aug 12, 2024

olevski commented Aug 27, 2024 • edited Loading

RenkuBot commented Sep 20, 2024

olevski commented Aug 2, 2024 •

edited

Loading

olevski commented Aug 2, 2024 •

edited by Panaetius

Loading

coveralls commented Aug 2, 2024 •

edited

Loading

olevski commented Aug 27, 2024 •

edited

Loading