Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Statistics database insert fails for long search terms #3321

Closed
sascha-egerer opened this issue Aug 15, 2022 · 0 comments · Fixed by #3322
Closed

[BUG] Statistics database insert fails for long search terms #3321

sascha-egerer opened this issue Aug 15, 2022 · 0 comments · Fixed by #3322

Comments

@sascha-egerer
Copy link
Collaborator

Describe the bug
If statistics are enabled a long search term ends up in a SQL error as the value exceed the field length.

To Reproduce

  1. Enable statistics
  2. Do a frontend search with a search term longer than 128 characters
  3. Check the error log
  4. Check the statistics database for your entry

Expected behavior
Search term should be cut to fit into the database field. SQL insert should not produce an error.

Used versions (please complete the following information):

  • TYPO3 Version: e.g. 11.5.14
  • EXT:solr Version: master
@sascha-egerer sascha-egerer mentioned this issue Aug 15, 2022
Merged
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this issue Aug 25, 2022
@sascha-egerer @dkd-kaehm
Ensure keywords string does not exceed database field length
8a4ec95 
The keywords field of the statistics database is only 128 characters
long. If a search keyword with more than 128 chars is used, the 
database insert fails if statistics are enabled.

Fixes: TYPO3-Solr#3321
Ports: TYPO3-Solr#3322
@dkd-kaehm dkd-kaehm mentioned this issue Aug 25, 2022
Merged
dkd-kaehm pushed a commit that referenced this issue Aug 25, 2022
@sascha-egerer @dkd-kaehm
Ensure keywords string does not exceed database field length
70b5cd9 
The keywords field of the statistics database is only 128 characters
long. If a search keyword with more than 128 chars is used, the 
database insert fails if statistics are enabled.

Fixes: #3321
Ports: #3322
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this issue Aug 26, 2022
@sascha-egerer @dkd-kaehm
Ensure keywords string does not exceed database field length
1875740 
The keywords field of the statistics database is only 128 characters
long. If a search keyword with more than 128 chars is used, the 
database insert fails if statistics are enabled.

Fixes: TYPO3-Solr#3321
Ports: TYPO3-Solr#3322
dkd-kaehm pushed a commit that referenced this issue Aug 26, 2022
@sascha-egerer @dkd-kaehm
Ensure keywords string does not exceed database field length
9f2c817 
The keywords field of the statistics database is only 128 characters
long. If a search keyword with more than 128 chars is used, the 
database insert fails if statistics are enabled.

Fixes: #3321
Ports: #3322
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Nov 2, 2022
@dkd-friedrich
[RELEASE] 11.2.1 - Maintenance Release
00a6edd 
This is a maintaine release for TYPO3 10.4, containing:

- [BUGFIX] Prepend wrong fe language on empty cache (TYPO3-Solr#3375)
- [TASK] Use TYPO3 IpAnonymizationUtility (TYPO3-Solr#3262)
- [BUGFIX:BP:11.2] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3202)
- [TASK] Fix scrutinizer on release-11.2.x
- [BUGFIX:BP:11.2] Do not handle page updates on new page with uid 0
(TYPO3-Solr#3338)
- [TASK] Remove not used strptime() adaption for windows.
- [BUGFIX] Respect indexing configuration for new and updated subpages
(TYPO3-Solr#3276)
- [BUGFIX] Ensure keywords string does not exceed database field length
(TYPO3-Solr#3321)
- [TASK:BP:11.2] Adapt column arrangement within sites config (TYPO3-Solr#3295)
- [DOCS:BP:11.2] add missing doc for ..pageIndexed (#)
- [BUGFIX] Fix PSR-4 Namespaces and Paths (TYPO3-Solr#3285)
- [BUGFIX] Silence DebugWriter for PageIndexerRequest (TYPO3-Solr#3030)
- [BUGFIX] AbstractSolrTask::setRootPageId(): Argument TYPO3-Solr#1 () must be
of type int, string given (TYPO3-Solr#3267)
- [BUGFIX:11.2] Update GarbageCollector.php (TYPO3-Solr#3249)
- [DOCS] Align with new TYPO3 documentation standards (TYPO3-Solr#3242)
- [DOCS] Align README.md with other extensions (TYPO3-Solr#3218)
- [BUGFIX] Missing dot in configuration in numberOfResultsPerGroup
method (TYPO3-Solr#3098
- [TASK] Added info about using page content in fields
- [TASK] Added info about the virtual field __solr_contents
- [BUGFIX:BP:11.2] Fix write connection (TYPO3-Solr#2916)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.1.3

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

Submit bug reports and feature requests on GitHub
Ask or help or answer questions in our Slack channel
Provide patches through Pull Request or review and comment on existing
Pull Requests
Go to www.typo3-solr.com or call dkd to sponsor the ongoing development
of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Nov 2, 2022
@dkd-friedrich
[RELEASE] 11.2.1 - Maintenance Release
634d13c 
This is a maintenance release for TYPO3 10.4, containing:

- [BUGFIX] Prepend wrong fe language on empty cache (TYPO3-Solr#3375)
- [TASK] Use TYPO3 IpAnonymizationUtility (TYPO3-Solr#3262)
- [BUGFIX:BP:11.2] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3202)
- [TASK] Fix scrutinizer on release-11.2.x
- [BUGFIX:BP:11.2] Do not handle page updates on new page with uid 0
(TYPO3-Solr#3338)
- [TASK] Remove not used strptime() adaption for windows.
- [BUGFIX] Respect indexing configuration for new and updated subpages
(TYPO3-Solr#3276)
- [BUGFIX] Ensure keywords string does not exceed database field length
(TYPO3-Solr#3321)
- [TASK:BP:11.2] Adapt column arrangement within sites config (TYPO3-Solr#3295)
- [DOCS:BP:11.2] add missing doc for ..pageIndexed (#)
- [BUGFIX] Fix PSR-4 Namespaces and Paths (TYPO3-Solr#3285)
- [BUGFIX] Silence DebugWriter for PageIndexerRequest (TYPO3-Solr#3030)
- [BUGFIX] AbstractSolrTask::setRootPageId(): Argument TYPO3-Solr#1 () must be
of type int, string given (TYPO3-Solr#3267)
- [BUGFIX:11.2] Update GarbageCollector.php (TYPO3-Solr#3249)
- [DOCS] Align with new TYPO3 documentation standards (TYPO3-Solr#3242)
- [DOCS] Align README.md with other extensions (TYPO3-Solr#3218)
- [BUGFIX] Missing dot in configuration in numberOfResultsPerGroup
method (TYPO3-Solr#3098
- [TASK] Added info about using page content in fields
- [TASK] Added info about the virtual field __solr_contents
- [BUGFIX:BP:11.2] Fix write connection (TYPO3-Solr#2916)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.2.1

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

Submit bug reports and feature requests on GitHub
Ask or help or answer questions in our Slack channel
Provide patches through Pull Request or review and comment on existing
Pull Requests
Go to www.typo3-solr.com or call dkd to sponsor the ongoing development
of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Nov 2, 2022
@dkd-friedrich
[RELEASE] 11.2.1 - Maintenance Release
47d5f74 
This is a maintenance release for TYPO3 10.4, containing:

- [BUGFIX] Prepend wrong fe language on empty cache (TYPO3-Solr#3375)
- [TASK] Use TYPO3 IpAnonymizationUtility (TYPO3-Solr#3262)
- [BUGFIX:BP:11.2] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3202)
- [TASK] Fix scrutinizer on release-11.2.x
- [BUGFIX:BP:11.2] Do not handle page updates on new page with uid 0
(TYPO3-Solr#3338)
- [TASK] Remove not used strptime() adaption for windows.
- [BUGFIX] Respect indexing configuration for new and updated subpages
(TYPO3-Solr#3276)
- [BUGFIX] Ensure keywords string does not exceed database field length
(TYPO3-Solr#3321)
- [TASK:BP:11.2] Adapt column arrangement within sites config (TYPO3-Solr#3295)
- [DOCS:BP:11.2] add missing doc for ..pageIndexed
- [BUGFIX] Fix PSR-4 Namespaces and Paths (TYPO3-Solr#3285)
- [BUGFIX] Silence DebugWriter for PageIndexerRequest (TYPO3-Solr#3030)
- [BUGFIX] AbstractSolrTask::setRootPageId(): Argument TYPO3-Solr#1 must be
of type int, string given (TYPO3-Solr#3267)
- [BUGFIX:11.2] Update GarbageCollector.php (TYPO3-Solr#3249)
- [DOCS] Align with new TYPO3 documentation standards (TYPO3-Solr#3242)
- [DOCS] Align README.md with other extensions (TYPO3-Solr#3218)
- [BUGFIX] Missing dot in configuration in numberOfResultsPerGroup
method (TYPO3-Solr#3098
- [TASK] Added info about using page content in fields
- [TASK] Added info about the virtual field __solr_contents
- [BUGFIX:BP:11.2] Fix write connection (TYPO3-Solr#2916)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.2.1

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

Submit bug reports and feature requests on GitHub
Ask or help or answer questions in our Slack channel
Provide patches through Pull Request or review and comment on existing
Pull Requests
Go to www.typo3-solr.com or call dkd to sponsor the ongoing development
of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-friedrich dkd-friedrich mentioned this issue Nov 2, 2022
Merged
dkd-friedrich added a commit that referenced this issue Nov 2, 2022
@dkd-friedrich
[RELEASE] 11.2.1 - Maintenance Release
92ab50f 
This is a maintenance release for TYPO3 10.4, containing:

- [BUGFIX] Prepend wrong fe language on empty cache (#3375)
- [TASK] Use TYPO3 IpAnonymizationUtility (#3262)
- [BUGFIX:BP:11.2] Shortcircuit work in SolrRoutingMiddleware (#3202)
- [TASK] Fix scrutinizer on release-11.2.x
- [BUGFIX:BP:11.2] Do not handle page updates on new page with uid 0
(#3338)
- [TASK] Remove not used strptime() adaption for windows.
- [BUGFIX] Respect indexing configuration for new and updated subpages
(#3276)
- [BUGFIX] Ensure keywords string does not exceed database field length
(#3321)
- [TASK:BP:11.2] Adapt column arrangement within sites config (#3295)
- [DOCS:BP:11.2] add missing doc for ..pageIndexed
- [BUGFIX] Fix PSR-4 Namespaces and Paths (#3285)
- [BUGFIX] Silence DebugWriter for PageIndexerRequest (#3030)
- [BUGFIX] AbstractSolrTask::setRootPageId(): Argument #1 must be
of type int, string given (#3267)
- [BUGFIX:11.2] Update GarbageCollector.php (#3249)
- [DOCS] Align with new TYPO3 documentation standards (#3242)
- [DOCS] Align README.md with other extensions (#3218)
- [BUGFIX] Missing dot in configuration in numberOfResultsPerGroup
method (#3098
- [TASK] Added info about using page content in fields
- [TASK] Added info about the virtual field __solr_contents
- [BUGFIX:BP:11.2] Fix write connection (#2916)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.2.1

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

Submit bug reports and feature requests on GitHub
Ask or help or answer questions in our Slack channel
Provide patches through Pull Request or review and comment on existing
Pull Requests
Go to www.typo3-solr.com or call dkd to sponsor the ongoing development
of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Ensure keywords string does not exceed database field length sascha-egerer/ext-solr
1 participant
@sascha-egerer