-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotation crash on „Video not available“ page #5941
Comments
It still crashes for me while using nightly build 141. Or is there a specific pr that is not merged yet that is supposed to fix this? |
I am using 0.21.0 , @HugeFrog24 @peat80 can you please provide a link you are facing the crash with? |
I tried premiere videos on my subscribed channels and they fail. |
yea , the bug is still there :( |
I was seeing the same on 0.21.1 so I went to try out v0.21.2_RC2 from #6052 to see if this was resolved already but it looks like it got "worse", as it doesn't even open the builtin crash reporter for me, just closes the app.
I can reproduce it with multiple available videos, including https://youtu.be/dQw4w9WgXcQ, just by rotating before the video itself is loaded. demo: screen-20210421-235137.2.mp4Crash log (from logcat)
|
This crash apparently also happens before a video loads.
Crash when rotate device before video loads when sharing Steps to reproduce the bug
Actual behaviourApp crashes Expected behaviorSwitch to landscape mode without crashing Screenshots/Screen recordingsLogsException
Crash log
Device info
|
The EmptyFragment should not have a constructor at all. Now a static methods creates the Fragment and arguments are handled via a Bundle.
fix Rotation crash on „Video not available“ page (#5941)
Nightly build 200 still crashes for me on rotation, but is supposed to have #6242 included. 🤔 |
Checklist
Steps to reproduce the bug
Actual behaviour
NewPipe throws an UI error
Expected behavior
Just rotate the page by 90°
Screenshots/Screen recordings
InShot_20210328_143635808.mp4
Logs
Exception
Crash log
Device info
The text was updated successfully, but these errors were encountered: