Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Rotation crash on „Video not available“ page (#5941) #6242

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

evermind-zz
Copy link
Contributor

@evermind-zz evermind-zz commented May 5, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • The EmptyFragment should not have a constructor at all.
  • Now a static methods creates the Fragment and arguments are handled via a Bundle.

Fixes the following issue(s)

Due diligence

The EmptyFragment should not have a constructor at all.
Now a static methods creates the Fragment and arguments
are handled via a Bundle.
@TobiGr
Copy link
Member

TobiGr commented May 5, 2021

Thank you! This seems to fix the crash, but unfortunately not the underlying bug.
Ensure to have slow internet. Open a video page, wait until the video starts playing. Then tap on a related stream and rotate the phone immediately. You'll be back on the video page you were before. Some states are not saved or restored correctly.

@TobiGr TobiGr added the bug Issue is related to a bug label May 5, 2021
@TobiGr TobiGr merged commit f98d263 into TeamNewPipe:dev Jun 3, 2021
This was referenced Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotation crash on „Video not available“ page
2 participants