Skip to content

Definition of Done

Daniel Spitzer edited this page Nov 3, 2016 · 2 revisions

DoD for a feature or fix from Issues List (https://github.com/Tradeshift/tradeshift-ui/issues)

  • Code is written
  • Code is tested
    • Has at least one unit test
      • Minimum test checks for component startup
      • Tested on Linux Chrome & Firefox (Latest)
    • Screenshot page(s) are added
      • Single page for the component
      • Shared page for multiple components
      • Tested on Win, Mac, Linux - Chrome, Firefox, Edge (latest) + IE9, 10, 11
  • Basic documentation written and deployed
    • All public APIs documented
    • Manual evaluation while making docs pages
  • Green build on Travis
    • Unit tests running and green
    • Screenshots taken and committed and diffed
  • PR is approved and merged to master
    • Manual screenshot approval process
  • Issue has a comment and label about status (notify designers and developers)

DoD for a sprint

  • Features all done in Project (in theory)
  • Beta release with changelog on Releases page
  • Beta release uploaded to S3
  • Previous beta release demoted to Tag

DoD for a release

  • Issues are closed in Milestone
  • Version is bumped
  • Changelog is written on Releases page
  • Previous beta release demoted to Tag
  • Binaries uploaded to S3
  • Documentation deployed