Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

整理: 辞書 DI によりテストを有効化 #1242

Merged
merged 14 commits into from
May 28, 2024
Merged

整理: 辞書 DI によりテストを有効化 #1242

merged 14 commits into from
May 28, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 14, 2024

内容

概要: 辞書 DI によりテストを有効化しリファクタリング

#1222 で UserDictionary クラスが追加され、辞書ファイルを DI 可能な設計になった。
これを利用し、テスト時の辞書ファイル指定をおこなった。
無効化されていたテストをこれにより有効化し、また実装可能となったスナップショットを追加した。

関連 Issue

@tarepan tarepan requested a review from a team as a code owner May 14, 2024 07:22
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 14, 2024 07:22
@tarepan tarepan mentioned this pull request May 14, 2024
Merged
Hiroshiba
Hiroshiba reviewed May 24, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！！
とても良いですね！！

test/e2e/conftest.py Outdated Show resolved Hide resolved
test/e2e/conftest.py Outdated Show resolved Hide resolved
test/e2e/conftest.py Outdated Show resolved Hide resolved
test/e2e/conftest.py Outdated Show resolved Hide resolved
test/e2e/conftest.py Outdated Show resolved Hide resolved
test/e2e/single_api/user_dict/test_user_dict_word.py Show resolved Hide resolved
@tarepan
Copy link
Contributor Author

tarepan commented May 24, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

This was referenced May 26, 2024
Closed
Merged
Merged
Hiroshiba
Hiroshiba reviewed May 28, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

マージします！

@Hiroshiba Hiroshiba merged commit 5bcab36 into VOICEVOX:master May 28, 2024
4 checks passed
@tarepan tarepan deleted the refactor/user_dict_di branch May 29, 2024 04:12
@tarepan tarepan mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarepan @Hiroshiba