Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Affinity #54

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

Client Affinity #54

wants to merge 65 commits into from

Conversation

gernest
Copy link
Contributor

@gernest gernest commented Jun 19, 2018 •
edited
Loading

Depends on #53

@gernest
delete networkRequest
e7a463d 
The struct was not necessary, it only wraps procedureInvocation without
adding any new functionality. It is much better just working with
procedureInvocation directy
@gernest
add procedureInvocation.handleTimeouts
35dddf8
@gernest
use context to manage goroutines
cb36f3d
@gernest
cleanup
a6f8b8f
@gernest
use blocking channel instead of forever loop
d80e7ae
@gernest
fix connection close
73e80a9
@gernest
partial working with sync
aeaba29
@gernest
ensure done is called
443e1e2
@gernest
refactor 8Conn.Drain
6145405 
remove unencessary drain channels
@gernest
remove unused code
1b54cc9
@gernest
cleanup
e23976b
@gernest
update QueryTImeout and ExecTimeout
fa0c3a7
@gernest
delete closed requests and more cleanups
8014df8
@gernest
improve error messages
a87dc73
@gernest
remove pings from nodeConn loop
6f1bd54
@gernest
fix *Conn.Drain
0572085
@gernest
correct count queued requests
3bbaa5d
@gernest
refactoring
0a35342 
-  move  response processing to one goroutine
- rework draining code
@gernest
return early for drainage calls on closed connections
44b1d85
@gernest
lower number of goroutines to 1 for async
1c4cb79
@gernest
Merge branch 'master' into timeout
bc9cbba 
* master:
  Update voltkv benchmark
@gernest
use 1 goroutine for async
ecea333
@gernest
add more info to error message
3a0aec6
@gernest
cleanup
c6b28b1
@gernest
don't panic
449aa75
@gernest
use a separate connection for results
097c811
@gernest
improvements
bfe82a4 
- fix request cancelation
- apply timeouts to @statistics,@SystemCatalog queries
- add the wuery string to the timeout error mesage
@gernest
don't run the benchmark in multiple goroutines
66d2717
@gernest
properly set context for *Conn.subscribeTopo
80de61e
@gernest
Update godoc
5ca6fa4
@gernest
Copy link
Contributor Author

gernest commented Jun 21, 2018 

var rst = map[string]voltdbclient.procedure{
	"VOTES.insert":            {SinglePartition: true, ReadOnly: false, PartitionParameter: 0, PartitionParameterType: 6},
	"AREA_CODE_STATE.delete":  {SinglePartition: false, ReadOnly: false, PartitionParameter: -1, PartitionParameterType: -1},
	"CONTESTANTS.delete":      {SinglePartition: false, ReadOnly: false, PartitionParameter: -1, PartitionParameterType: -1},
	"CONTESTANTS.insert":      {SinglePartition: false, ReadOnly: false, PartitionParameter: -1, PartitionParameterType: -1},
	"Initialize":              {SinglePartition: false, ReadOnly: false, PartitionParameter: -1, PartitionParameterType: -1},
	"AREA_CODE_STATE.upsert":  {SinglePartition: false, ReadOnly: false, PartitionParameter: -1, PartitionParameterType: -1},
	"CONTESTANTS.upsert":      {SinglePartition: false, ReadOnly: false, PartitionParameter: -1, PartitionParameterType: -1},
	"GetStateHeatmap":         {SinglePartition: false, ReadOnly: true, PartitionParameter: -1, PartitionParameterType: -1},
	"Vote":                    {SinglePartition: true, ReadOnly: false, PartitionParameter: 0, PartitionParameterType: 6},
	"CONTESTANTS.update":      {SinglePartition: false, ReadOnly: false, PartitionParameter: -1, PartitionParameterType: -1},
	"ContestantWinningStates": {SinglePartition: false, ReadOnly: true, PartitionParameter: -1, PartitionParameterType: -1},
	"Results":                 {SinglePartition: false, ReadOnly: true, PartitionParameter: -1, PartitionParameterType: -1},
	"AREA_CODE_STATE.insert":  {SinglePartition: false, ReadOnly: false, PartitionParameter: -1, PartitionParameterType: -1},
	"AREA_CODE_STATE.update":  {SinglePartition: false, ReadOnly: false, PartitionParameter: -1, PartitionParameterType: -1},
}

@gernest gernest changed the title [W.I.P] Client Affinity Client Affinity Jun 24, 2018
@gernest
Copy link
Contributor Author

gernest commented Jun 26, 2018 •
edited
Loading 

TIMESTAMP      HOST_ID  HOSTNAME  SITE_ID  PARTITION_ID  PROCEDURE                       INVOCATIONS  TIMED_INVOCATIONS  MIN_EXECUTION_TIME  MAX_EXECUTION_TIME  AVG_EXECUTION_TIME  MIN_RESULT_SIZE  MAX_RESULT_SIZE  AVG_RESULT_SIZE  MIN_PARAMETER_SET_SIZE  MAX_PARAMETER_SET_SIZE  AVG_PARAMETER_SET_SIZE  ABORTS  FAILURES  TRANSACTIONAL 
-------------- -------- --------- -------- ------------- ------------------------------- ------------ ------------------ ------------------- ------------------- ------------------- ---------------- ---------------- ---------------- ----------------------- ----------------------- ----------------------- ------- --------- --------------
 1530009449115        0 mj               0             2 add_customer                               1                  1             1291353             1291353             1291353               47               47               47                      28                      28                      28       0         0              1
 1530009449115        0 mj               4         16383 org.voltdb.sysprocs.AdHoc_RO_MP            1                  1             6477318             6477318             6477318               84               84               84                    1124                    1124                    1124       0         0              1
 1530009449116        1 mj               2             2 add_customer                               1                  1             1412395             1412395             1412395               47               47               47                      28                      28                      28       0         0              1

(Returned 3 rows in 0.00s)

@gernest
dump more output on test
16a47c9
@gernest
log nodes used
ed96403
@gernest
update client affinity tests
2d49010 
- add more debugging info
- test against topology, no need to query voltdb for procedure stats
@gernest
add comment about the client affinity test
6c62807
@gernest
refactor affinity logging
972ee0f 
- don't sort the affinity logs in test
- pass more meaningful parameters to selectedNode callback
@gernest
add nil check
46350b2
@gernest
only run 10 queries
873d9f7
@gernest
log INITIATOR table in the affinity tests
2bdb529
@gernest
Update TestVerifyClientAffinity
98bc24b 
Check if the host_id of the nodes are in the initiator table.
@gernest
sign fill the hash value from hashinator
055a297 
The refrence java code uses >>> which go doesnt have, we are using >> which will zero
fill when the value is unsigned, by using signed int we are now having
similar results to java.
@gernest
cleanup
c6b775c 
- remove unecessary type cast
@gernest
cleanup TestClientAffinity
fb10172 
- rely on AFFINITY_SERVERS to pickup  cluster server
- don't generate a topology file
-  remove hashinator tests, these are already covered
@gernest gernest mentioned this pull request Aug 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gernest