Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Affinity #54

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

Client Affinity #54

wants to merge 65 commits into from

Commits on Jun 11, 2018

  1. delete networkRequest 

    The struct was not necessary, it only wraps procedureInvocation without
adding any new functionality. It is much better just working with
procedureInvocation directy
    @gernest
    gernest committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    e7a463d View commit details
    Browse the repository at this point in the history

  2. add procedureInvocation.handleTimeouts

    @gernest
    gernest committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    35dddf8 View commit details
    Browse the repository at this point in the history

  3. use context to manage goroutines

    @gernest
    gernest committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    cb36f3d View commit details
    Browse the repository at this point in the history

  4. cleanup

    @gernest
    gernest committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    a6f8b8f View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2018

  1. use blocking channel instead of forever loop

    @gernest
    gernest committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    d80e7ae View commit details
    Browse the repository at this point in the history

  2. fix connection close

    @gernest
    gernest committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    73e80a9 View commit details
    Browse the repository at this point in the history

  3. partial working with sync

    @gernest
    gernest committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    aeaba29 View commit details
    Browse the repository at this point in the history

  4. ensure done is called

    @gernest
    gernest committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    443e1e2 View commit details
    Browse the repository at this point in the history

  5. refactor 8Conn.Drain 

    remove unencessary drain channels
    @gernest
    gernest committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    6145405 View commit details
    Browse the repository at this point in the history

  6. remove unused code

    @gernest
    gernest committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    1b54cc9 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2018

  1. cleanup

    @gernest
    gernest committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    e23976b View commit details
    Browse the repository at this point in the history

  2. update QueryTImeout and ExecTimeout

    @gernest
    gernest committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    fa0c3a7 View commit details
    Browse the repository at this point in the history

  3. delete closed requests and more cleanups

    @gernest
    gernest committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    8014df8 View commit details
    Browse the repository at this point in the history

  4. improve error messages

    @gernest
    gernest committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    a87dc73 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2018

  1. remove pings from nodeConn loop

    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    6f1bd54 View commit details
    Browse the repository at this point in the history

  2. fix *Conn.Drain

    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    0572085 View commit details
    Browse the repository at this point in the history

  3. correct count queued requests

    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    3bbaa5d View commit details
    Browse the repository at this point in the history

  4. refactoring 

    -  move  response processing to one goroutine
- rework draining code
    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    0a35342 View commit details
    Browse the repository at this point in the history

  5. return early for drainage calls on closed connections

    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    44b1d85 View commit details
    Browse the repository at this point in the history

  6. lower number of goroutines to 1 for async

    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    1c4cb79 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into timeout 

    * master:
  Update voltkv benchmark
    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    bc9cbba View commit details
    Browse the repository at this point in the history

  8. use 1 goroutine for async

    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    ecea333 View commit details
    Browse the repository at this point in the history

  9. add more info to error message

    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    3a0aec6 View commit details
    Browse the repository at this point in the history

  10. cleanup

    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    c6b28b1 View commit details
    Browse the repository at this point in the history

  11. don't panic

    @gernest
    gernest committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    449aa75 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2018

  1. use a separate connection for results

    @gernest
    gernest committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    097c811 View commit details
    Browse the repository at this point in the history

  2. improvements 

    - fix request cancelation
- apply timeouts to @statistics,@SystemCatalog queries
- add the wuery string to the timeout error mesage
    @gernest
    gernest committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    bfe82a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2018

  1. don't run the benchmark in multiple goroutines

    @gernest
    gernest committed Jun 16, 2018
    Configuration menu
    Copy the full SHA
    66d2717 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2018

  1. properly set context for *Conn.subscribeTopo

    @gernest
    gernest committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    80de61e View commit details
    Browse the repository at this point in the history

  2. Update godoc

    @gernest
    gernest committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    5ca6fa4 View commit details
    Browse the repository at this point in the history

  3. add draining logs messages

    @gernest
    gernest committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    6c4aa54 View commit details
    Browse the repository at this point in the history

  4. refactor 

    - setwrite deadline to 1 second
- close the connection on any tcp read error
    @gernest
    gernest committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    10a60f7 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2018

  1. fixed tests

    @gernest
    gernest committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    da15119 View commit details
    Browse the repository at this point in the history

  2. initial work on client addinity 

    - fix hasType, the server returns ELASTIC not Elastic

- add tests
- cleanup partiion details, have them in a single struct
    @gernest
    gernest committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    1b89ea3 View commit details
    Browse the repository at this point in the history

  3. cleanup 

    - remove unused code
    @gernest
    gernest committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    a12a4c5 View commit details
    Browse the repository at this point in the history

  4. move all partition metadata to PartitionDetails struct

    @gernest
    gernest committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    db3fb0e View commit details
    Browse the repository at this point in the history

  5. fix typo

    @gernest
    gernest committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    25f56e8 View commit details
    Browse the repository at this point in the history

  6. refactor 

    - remove unnecessary use of pointers
- update affomoty tests
    @gernest
    gernest committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    820433f View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2018

  1. get client affinity to work

    @gernest
    gernest committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    258fad3 View commit details
    Browse the repository at this point in the history

  2. update 

    - add more comments
- fallback when client affinity picks a dead node
    @gernest
    gernest committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    0b4c000 View commit details
    Browse the repository at this point in the history

  3. fix race condition

    @gernest
    gernest committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    8e37d89 View commit details
    Browse the repository at this point in the history

  4. update client affinity

    @gernest
    gernest committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    687aa7c View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2018

  1. fix error handling/reporting

    @gernest
    gernest committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    822493d View commit details
    Browse the repository at this point in the history

  2. fix reading topology repicas details

    @gernest
    gernest committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    81c46da View commit details
    Browse the repository at this point in the history

  3. cleanup backpressure 

    This seems to be irrelevant
    @gernest
    gernest committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    8ca6097 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @gernest
    gernest committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    55d2a88 View commit details
    Browse the repository at this point in the history

  5. fix getConnByCA api change

    @gernest
    gernest committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    5d15d75 View commit details
    Browse the repository at this point in the history

  6. cleanup

    @gernest
    gernest committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    eeed6cf View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2018

  1. add test to ensure we pick the right master

    @gernest
    gernest committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    57b7885 View commit details
    Browse the repository at this point in the history

  2. dump topology details

    @gernest
    gernest committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    69eadf9 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2018

  1. add TestVerifyClientAffinity

    @gernest
    gernest committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    7944eeb View commit details
    Browse the repository at this point in the history

  2. collect only stats about add_customer procedure

    @gernest
    gernest committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    c67154c View commit details
    Browse the repository at this point in the history

  3. update tests 

    - add more specific assertions
    @gernest
    gernest committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    6f6d173 View commit details
    Browse the repository at this point in the history

  4. dump more output on test

    @gernest
    gernest committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    16a47c9 View commit details
    Browse the repository at this point in the history

  5. log nodes used

    @gernest
    gernest committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    ed96403 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2018

  1. update client affinity tests 

    - add more debugging info
- test against topology, no need to query voltdb for procedure stats
    @gernest
    gernest committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    2d49010 View commit details
    Browse the repository at this point in the history

  2. add comment about the client affinity test

    @gernest
    gernest committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    6c62807 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2018

  1. refactor affinity logging 

    - don't sort the affinity logs in test
- pass more meaningful parameters to selectedNode callback
    @gernest
    gernest committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    972ee0f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2018

  1. add nil check

    @gernest
    gernest committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    46350b2 View commit details
    Browse the repository at this point in the history

  2. only run 10 queries

    @gernest
    gernest committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    873d9f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2018

  1. log INITIATOR table in the affinity tests

    @gernest
    gernest committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    2bdb529 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2018

  1. Update TestVerifyClientAffinity 

    Check if the host_id of the nodes are in the initiator table.
    @gernest
    gernest committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    98bc24b View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. sign fill the hash value from hashinator 

    The refrence java code uses >>> which go doesnt have, we are using >> which will zero
fill when the value is unsigned, by using signed int we are now having
similar results to java.
    @gernest
    gernest committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    055a297 View commit details
    Browse the repository at this point in the history

  2. cleanup 

    - remove unecessary type cast
    @gernest
    gernest committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    c6b775c View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. cleanup TestClientAffinity 

    - rely on AFFINITY_SERVERS to pickup  cluster server
- don't generate a topology file
-  remove hashinator tests, these are already covered
    @gernest
    gernest committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    fb10172 View commit details
    Browse the repository at this point in the history