-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native: Fix @-mentions UI to allow @ character in posts #24428
React Native: Fix @-mentions UI to allow @ character in posts #24428
Conversation
Size Change: -1.03 MB (89%) 🏆 Total Size: 1.15 MB
ℹ️ View Unchanged
|
This fixes a bug with the @-mention feature that made entering the standalone @ character difficult because of the @-mention UI getting in the way. The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic.
7237a57
to
43e35c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested via wordpress-mobile/WordPress-iOS#14596
Working great as described. Nice job @guarani ! 🎉
On a side note: I wonder about the reasoning behind choosing this particular solution. Personally I'd say that dismissing the UI adding a space is more natural without breaking the typing flow. That's also how web does it too. But probably having all the ways implemented is the best option anyway 👍
Thanks a lot for the review, @etoledom!
Supporting dismissing the UI via backspace brings iOS behavior in-line with Android. We do plan to support on both platforms in the future the "space to dismiss" approach described in the issue this addresses:
|
Amazing, thank you! 🙏 |
* Release script: Update react-native-editor version to 1.33.0 * Update release notes. * Update version numbers for packages. * Revert "Reduce spacing between label and slider control (#23580)" (#24109) This reverts commit 2a67de0. * Release script: Update react-native-* versions to 1.33.1 * Release script: Update with changes from 'npm run core preios' * Allow @ char in posts in mobile editor (#24428) This fixes a bug with the @-mention feature on mobile that made entering the standalone @ character difficult because of the @-mention UI getting in the way. The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic. * Remove duplicate entry from changelog Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
* Release script: Update react-native-editor version to 1.33.0 * Update release notes. * Update version numbers for packages. * Revert "Reduce spacing between label and slider control (#23580)" (#24109) This reverts commit 2a67de0. * Release script: Update react-native-* versions to 1.33.1 * Release script: Update with changes from 'npm run core preios' * Allow @ char in posts in mobile editor (#24428) This fixes a bug with the @-mention feature on mobile that made entering the standalone @ character difficult because of the @-mention UI getting in the way. The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic. * Remove duplicate entry from changelog Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
* Release script: Update react-native-editor version to 1.34.0 * [RNMobile] E2E Android - Use swipe gesture to scroll inserter menu (#24338) * Set autosaveInterval to 1 on mobile (#24353) * Revert "[RNMobile] Fix jumping toolbar (#23684)" (#24388) This reverts commit d86cd5f. * Turn off autosave interval for mobile (#24415) * [RNMobile] Merge release 1.33.1 to master (#24448) * Release script: Update react-native-editor version to 1.33.0 * Update release notes. * Update version numbers for packages. * Revert "Reduce spacing between label and slider control (#23580)" (#24109) This reverts commit 2a67de0. * Release script: Update react-native-* versions to 1.33.1 * Release script: Update with changes from 'npm run core preios' * Allow @ char in posts in mobile editor (#24428) This fixes a bug with the @-mention feature on mobile that made entering the standalone @ character difficult because of the @-mention UI getting in the way. The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic. * Remove duplicate entry from changelog Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> * Update version numbers * Ran pod install to update podfile.lock Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Adam Zielinski <adam@adamziel.com> Co-authored-by: Chip <chip.snyder3@gmail.com> Co-authored-by: Cameron Voell <cameronvoell@gmail.com> Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
Description
Addresses #24425
This address a bug with the @-mention feature that made entering the standalone @ character difficult because of the @-mention UI getting in the way.
The fix here is to allow the @ character to be intercepted without being consumed by the key event logic. This addresses one aspect of proposed fix for the issue linked above:
How has this been tested?
Screenshots
Types of changes
Checklist: