Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue with BVL Feedback popup #1041

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Fixing issue with BVL Feedback popup #1041

merged 1 commit into from
Apr 17, 2015

Conversation

rathisekaran
Copy link
Contributor

  • Removing misplaced comma in the join statement
  • Fixing type in function name

@rathisekaran rathisekaran added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Apr 16, 2015
@rathisekaran rathisekaran added this to the 15.04 milestone Apr 16, 2015
samirdas added a commit that referenced this pull request Apr 17, 2015
@samirdas
Merge pull request #1041 from rathisekaran/bvl_feedback_fix
9956534 
Fixing issue with BVL Feedback popup
@samirdas samirdas merged commit 9956534 into aces:master Apr 17, 2015
driusan pushed a commit that referenced this pull request Feb 27, 2024
@jeffersoncasimir
[electrophysiology_browser] Replace Physiological Annotations with Ev…
1112e1a 
…ents (#9032)

This aims to improve the current compliance to the BIDS standard. Loris-MRI counterpart: #1041
Partially addresses #8910.

This replaces references to annotation files with references to event files.

This deletes *_annotation_* tables. The corresponding required event tables already exist.

+minor improvements to the EventManager and AnnotationForm components.
driusan pushed a commit that referenced this pull request Mar 19, 2024
@jeffersoncasimir
[electrophysiology_browser] HED Tag Support (#9033)
659cc70 
This adds more robust HED tag support. Closes #8910.

It adds SQL tables to store HED schemas as hierarchical nodes and to store the assembled HED strings as node references using a modified linked list data structure, allowing for complex groupings.

Instance-level tags which were ingested in the HED column of events.tsv files can be viewed in the EventManager component and can be edited in a limited (see below) way in the AnnotationForm component.

There is a new component called DatasetTagger which is accessible via the "Dataset Tag Manager" button at the bottom left corner of the browser. This component enables the modification of HED tags at the dataset-wide level (events.json). This will associate HED tags to Event attributes for all events in the dataset containing the respective attributes. This component enables virtually unlimited groupings of HED tags, as well their addition and removal.

Limitations:

    "Value" HED tags are not supported
    "Expanded Definitions" are not supported
    Editing the "Level description" via the "Dataset Tag Manager" is not currently supported (coming soon)
    Session-level events.json overriding and assignment not currently supported.
    Adding HED tags on an event level is currently limited to: SCORE artifacts (if SCORE schema ingested) and tags that were previously added via the ingestion of the events.json or manually via the Dataset Tag Manager.

Related: Loris-MRI/#1041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
15.04
Development

Successfully merging this pull request may close these issues.
2 participants
@rathisekaran @samirdas