Ws example fix #1193
Merged
Ws example fix #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 19, 2016 18:06
…pe' to fix import error in the web socket server example.
… in the web socket server example.
Current coverage is 98.34% (diff: 100%)@@ master #1193 diff @@
==========================================
Files 29 29
Lines 6533 6533
Methods 0 0
Messages 0 0
Branches 1095 1095
==========================================
Hits 6425 6425
Misses 56 56
Partials 52 52
|
asvetlov
requested changes
Sep 20, 2016
| @@ -5,7 +5,7 @@ | |||
| import asyncio | |||
| import os | |||
|
|
|||
| from aiohttp.web import (Application, Response, WebSocketResponse, WSMsgType, | |||
| from aiohttp.web import (Application, MsgType, Response, WebSocketResponse, | |||
There was a problem hiding this comment.
MsgType is a deprecated name in favor of WSMsgType.
| @@ -27,7 +27,7 @@ | |||
| request.app['sockets'].append(resp) | |||
|
|
|||
| async for msg in resp: | |||
| if msg.type == WSMsgType.TEXT: | |||
| if msg.type == MsgType.TEXT: | |||
|
Thanks! |
|
Glad to be able to help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This minimal pull request fixes depreceated API usage in the
examples/web_ws.pyexample.Are there changes in behavior for the user?
Users should now be able to run the
examples/web_ws.pyexample without any problems.Checklist
CONTRIBUTORS.txtCHANGES.rst#isuue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.