Add missing WSMsgType to web_ws.__all__ #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
approved these changes
Sep 21, 2016
|
done. changes updated. |
asvetlov
pushed a commit
that referenced
this pull request
Sep 21, 2016
* Use 'aiohttp.web.MsgType' instead of depreceated 'aiohttp.web.WSMsgType' to fix import error in the web socket server example. * Remove explicit loop specification for 'aiohttp.web.run_app' function in the web socket server example. * Sort imports in the web socket server example script. * Replace the 'MsgType' back with 'WSMsgType' as #1200 fixes the import error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add
WSMsgTypetoweb_ws.__all__as it was missing there.Are there changes in behavior for the user?
from aiohttp.web import WSMsgTypewill workRelated issue number
#1193