-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using the subtraction operator to get the relative path between URLs #1340
Conversation
Looks like the tests aren't passing in the CI |
Sorry about the conflicts. I was doing a bit of housekeeping to better organize internals. I think I've worked them out correctly. |
Co-authored-by: J. Nick Koston <nick@koston.org>
I have also noticed that when using |
The windows wheel build is failing the tests You probably want to use PosixPurePath instead so windows doesn’t try to use windows path separators |
CodSpeed Performance ReportMerging #1340 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
+ Coverage 95.97% 96.02% +0.04%
==========================================
Files 31 31
Lines 5645 5707 +62
Branches 349 355 +6
==========================================
+ Hits 5418 5480 +62
Misses 201 201
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: J. Nick Koston <nick@koston.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oleksbabieiev
@oleksbabieiev Would you please address the additional comments in a followup PR? |
@bdraco yes, but I won't be able to do it until tomorrow. Sorry for the inconvenience |
no worries. thank you! opened #1377 so I don't loose track |
I looks like I jumped the gun and merged this too soon. It needs a little more work before its ready. I opened #1391 to revert it and the work I did on top of it to try to get it into a good state. Sorry I didn't realize it sooner. |
What do these changes do?
Support for using the subtraction operator to calculate the difference between the paths of two URLs. A new URL with the relative path is returned to the user.
Usage:
Are there changes in behavior for the user?
Now the user can easily calculate the relative path between two URLs!
Related issue number
Resolves #1183
Checklist