-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert URL subtraction #1391
Revert URL subtraction #1391
Conversation
It appears we merged the URL subtraction a bit too soon, and we need to rework the approach. I know have ~20 hours into it trying to solve the issues. The conclusion is that it is not ready to ship and we need a new approach. To ensure it does not go out before its ready, revert the original PR and the attempts to solve the issues with it so we can start fresh. References
CodSpeed Performance ReportMerging #1391 will not alter performanceComparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1391 +/- ##
==========================================
- Coverage 96.05% 96.00% -0.06%
==========================================
Files 31 31
Lines 5784 5683 -101
Branches 361 353 -8
==========================================
- Hits 5556 5456 -100
+ Misses 202 201 -1
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We merged the URL subtraction a bit too soon, and we need to rework the approach. I now have ~20 hours into it trying to solve the issues. The conclusion is that it is not ready to ship and we need a new approach. I sincerely hope that a revert will not dissuade a second attempt.
To ensure it does not go out before its ready, revert the original PR and the followup attempts to solve the issues with it so we can start fresh.
We have the following known issues that we don't have a solution for right now:
O(base_path_segments * target_path_segments)
and its the slowest benchmark we have in the library right now:References
#1340
#1388
#1379
#1382