Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of calculate_relative_path #1382

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 22, 2024

followup to #1340

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 22, 2024
Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #1382 will improve performances by 15.96%

Comparing try_to_optimize_calculate_relative_path (a020004) with master (ef0b5e3)

Summary

⚡ 1 improvements
✅ 83 untouched benchmarks

Benchmarks breakdown

Benchmark master try_to_optimize_calculate_relative_path Change
test_url_subtract 15.7 ms 13.6 ms +15.96%

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (ef0b5e3) to head (a020004).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1382   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files          31       31           
  Lines        5751     5752    +1     
  Branches      360      360           
=======================================
+ Hits         5524     5525    +1     
  Misses        201      201           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 96.05% <100.00%> (+<0.01%) ⬆️
MyPy 45.96% <100.00%> (+<0.01%) ⬆️
OS-Linux 99.55% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.61% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.29% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.46% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.52% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.55% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.29% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.55% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.61% <100.00%> (+<0.01%) ⬆️
pytest 99.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Oct 22, 2024

that didn't help.. because the __hash__ implementation is really slow

@bdraco bdraco marked this pull request as ready for review October 22, 2024 22:35
@bdraco bdraco merged commit 9348e88 into master Oct 22, 2024
44 of 46 checks passed
@bdraco bdraco deleted the try_to_optimize_calculate_relative_path branch October 22, 2024 22:35
@bdraco bdraco mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant