Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove abstract fields when disableESTransforms is enabled #732

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Remove abstract fields when disableESTransforms is enabled #732

merged 1 commit into from
Aug 2, 2022

Commits on Aug 2, 2022

  1. Remove abstract fields when disableESTransforms is enabled 

    Fixes #731

`disableESTransforms` is intended to match the more spec-compliant mode
`useDefineForClassFields` provided by TypeScript, but it looks like in TS 4.2
they updated the behavior so that `abstract` fields are removed in addition to
`declare` fields:
microsoft/TypeScript#40699

In Sucrase, we can implement the same behavior by simply testing for `abstract`
as well in the place where we test for `declare`.
    @alangpierce
    alangpierce committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    07196e5 View commit details
    Browse the repository at this point in the history