feat(spec): add customRequest methods #178
Conversation
shortcuts
changed the title
shortcuts
force-pushed
the
feat/APIC-339/customRequests
branch
from
de15963
to
96e59ec
Compare
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
| */ | ||
| private Call getCustomRequestCall( | ||
| String path, | ||
| Object body, |
There was a problem hiding this comment.
Is there a way to specify queryParams ? Maybe with an helper
There was a problem hiding this comment.
Do you mean having a clearer name?
There was a problem hiding this comment.
body is just body right ? The list of queryParams will always be empty in this function (it can be passed inside the path but it defeats the purpose of having an api client)
There was a problem hiding this comment.
Ohhhh you commented on the get request I did not get it sorry, I'll try to make it query params!
|
|
||
| import { exists, run, toAbsolutePath } from './common'; | ||
| import { createSpinner } from './oraLog'; | ||
| import type { Spec } from './pre-gen/setHostsOptions'; | ||
|
|
||
| async function propagateTagsToOperations( |
There was a problem hiding this comment.
This could have been a separate PR
…-clients-automation into feat/APIC-339/customRequests
| description: This method allow you to send requests to the Algolia REST API. | ||
| parameters: | ||
| - $ref: '#/PathInPath' | ||
| - name: parameters |
There was a problem hiding this comment.
Can you also add this to the others method ? I don't know if queryParams are restricted to GET in our api
There was a problem hiding this comment.
I thought I already did 🤔 You are right, this should do it: d4cd002
…-clients-automation into feat/APIC-339/customRequests
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-339
Changes included:
Real changes are in
scripts/buildSpecs.tsandcommonspecs, all of the other are automatically generated.propagateTagsToOperationsthat runs beforebuildSpec, which allows us to:customRequestdefinition that will be used for each clientstagsdefinition from eachpathsfile, this option can now be globally defined in the main<clientName>/spec.ymlfile.pathtemplate parameter torequestPath, to avoid conflict with parameters of the same name.batchandmultipleBatchparameters🧪 Test
CI :D
The CI might not pass before #179 is merged if cache is invalidated