fix(spec): better filters type #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
shortcuts
force-pushed
the
fix/APIC-345/specs-types
branch
2 times, most recently
from
72cafab
to
16e98ae
Compare
|
This PR is blocked until the Java generator can handle oneOfs without data type in property name ➕ |
shortcuts
force-pushed
the
fix/APIC-345/specs-types
branch
from
16e98ae
to
f5542fc
Compare
|
There is still an issue on the CTS side, I'll wait for @millotp to continue debugging as it's out of my Java skills |
shortcuts
force-pushed
the
fix/APIC-345/specs-types
branch
from
f5542fc
to
9552944
Compare
shortcuts
force-pushed
the
fix/APIC-345/specs-types
branch
from
9552944
to
f360137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-345
closes #177
Changes included:
filtersrelated options typessearchParamsmissing options and typestagsthat I forgot feat(spec): add customRequest methods #178Blockers:
This
oneOfis not handled by the Java client, we should iterate on that before merging this PR @millotp🧪 Test
CI :D