fix(spec): better filters type #413

shortcuts · 2022-04-21T15:54:15Z

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-345

closes #177

Changes included:

Fix filters related options types
Fix searchParams missing options and types

(idk what happened with #227, but it was closed after rebase/force pushing)

🧪 Test

CI :D

netlify · 2022-04-21T15:54:20Z

✅ Deploy Preview for api-clients-automation ready!

Name	Link
🔨 Latest commit	`6a8db07`
🔍 Latest deploy log	https://app.netlify.com/sites/api-clients-automation/deploys/6267ebaaa48af40008f60741
😎 Deploy Preview	https://deploy-preview-413--api-clients-automation.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

algolia-bot · 2022-04-21T15:55:29Z

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

generators/src/main/java/com/algolia/codegen/cts/ParametersWithDataType.java

shortcuts · 2022-04-22T15:22:51Z

generators/src/main/java/com/algolia/codegen/cts/ParametersWithDataType.java

+        // Somehow this is not yet enough
+        if (oneOf != null && !oneOf.isEmpty()) {
+          return oneOf.get(0);
+        }


This takes the first item of the list, it's not correct but allow the CI to work for now

millotp

nice ! closer to the true API !

generators/src/main/java/com/algolia/codegen/cts/ParametersWithDataType.java

millotp · 2022-04-25T15:16:55Z

generators/src/main/java/com/algolia/codegen/cts/ParametersWithDataType.java

@@ -466,7 +494,18 @@ private IJsonSchemaValidationProperties findMatchingOneOf(
      return bestOneOf;
    }
    if (param instanceof List) {
-      // no idea for list
+      // NICE ---> no idea for list <--- NICE


sorry for this, I'll right better error exception next time

Nah actually I like this way of thinking!!

tests/CTS/methods/requests/templates/java/maybeConvertOneOf.mustache

millotp · 2022-04-26T07:43:31Z

.github/workflows/check.yml

@@ -222,7 +222,7 @@ jobs:
        with:
          path: |
            ${{ format('{0}/algoliasearch-core/src/com/algolia/api/{1}.java', matrix.client.path, matrix.client.api) }}
-            ${{ format('{0}/algoliasearch-core/src/com/algolia/model/{1}/**', matrix.client.path, matrix.client.capitalizedName) }}
+            ${{ format('{0}/algoliasearch-core/src/com/algolia/model/{1}/**', matrix.client.path, matrix.client.name) }}


it's not name, it's camelCase, not sure it's available

Ahhh yes good catch I did not thought of the querySuggestions ones for example

millotp · 2022-04-26T07:59:09Z

scripts/cts/utils.ts

+ *
+ * `search-client`, `javascript` -> `searchClient`.
+ */
+export function createClientName(client: string, language: string): string {


much cleaner like that 👍

(hopefully it works now D:)

except the cache got skipped ahah

Ah yes it ran just before ._. oh god

Ah no it's good!!!

Do I need to change something on my PHP test branch ? :o

Not yet but you should merge first, there's still an issue with the CI for Java, I'll come back to it later

millotp

Youpi let's go ! 💯

shortcuts · 2022-04-26T12:31:47Z

Hmm the deleted files are still not pushed...................

millotp · 2022-04-26T12:32:21Z

You can do it in another PR, this one is already packed ahah

shortcuts · 2022-04-26T12:32:37Z

You can do it in another PR, this one is already packed ahah

Yup I won't do it in this one, just testing locally why

shortcuts commented Apr 21, 2022

View reviewed changes

generators/src/main/java/com/algolia/codegen/cts/ParametersWithDataType.java Outdated Show resolved Hide resolved

shortcuts mentioned this pull request Apr 22, 2022

fix(spec): remove tags from specs #415

Merged

fix(javascript): add missing descriptions

6e3d1e2

shortcuts mentioned this pull request Apr 22, 2022

fix(javascript): add missing descriptions #416

Merged

shortcuts changed the base branch from main to fix/js-template April 22, 2022 15:02

shortcuts force-pushed the fix/APIC-345/specs-types branch from af5b014 to 0707ba0 Compare April 22, 2022 15:17

fix(spec): better filters type

d2d08d8

shortcuts force-pushed the fix/APIC-345/specs-types branch from 0707ba0 to d2d08d8 Compare April 22, 2022 15:21

shortcuts commented Apr 22, 2022

View reviewed changes

shortcuts marked this pull request as ready for review April 25, 2022 09:49

shortcuts requested review from a team, damcou and millotp and removed request for a team April 25, 2022 09:49

shortcuts self-assigned this Apr 25, 2022

Base automatically changed from fix/js-template to main April 25, 2022 09:58

shortcuts added 3 commits April 25, 2022 13:08

Merge branch 'main' into fix/APIC-345/specs-types

83c545f

fix CTS gen

afa41a2

re-add skipped file

78eb47d

millotp reviewed Apr 25, 2022

View reviewed changes

review

4c85d84

shortcuts requested a review from millotp April 25, 2022 16:01

shortcuts added 3 commits April 25, 2022 18:27

Merge branch 'main' into fix/APIC-345/specs-types

a080906

cache path

885caa8

cache path part 2

d8e0de3

millotp reviewed Apr 26, 2022

View reviewed changes

add camlizedName

b52c935

millotp previously approved these changes Apr 26, 2022

View reviewed changes

shortcuts marked this pull request as draft April 26, 2022 10:43

retrieve code from gen branch?

4f8d75c

shortcuts mentioned this pull request Apr 26, 2022

fix(script): no branch change on codegen #431

Merged

shortcuts added 2 commits April 26, 2022 13:45

remove checkout files

7439f69

Merge branch 'main' into fix/APIC-345/specs-types

1ea4181

shortcuts marked this pull request as ready for review April 26, 2022 12:06

millotp previously approved these changes Apr 26, 2022

View reviewed changes

Merge branch 'main' into fix/APIC-345/specs-types

24cab30

shortcuts dismissed millotp’s stale review via 24cab30 April 26, 2022 12:19

millotp approved these changes Apr 26, 2022

View reviewed changes

Merge branch 'main' into fix/APIC-345/specs-types

6a8db07

millotp approved these changes Apr 26, 2022

View reviewed changes

shortcuts mentioned this pull request Apr 26, 2022

fix(ci): rm deleted files #432

Merged

shortcuts enabled auto-merge (squash) April 26, 2022 13:00

shortcuts merged commit 2838123 into main Apr 26, 2022

shortcuts deleted the fix/APIC-345/specs-types branch April 26, 2022 13:04

This was referenced Apr 28, 2022

chore: release 2022-04-28 #445

Closed

chore: release 2022-04-28 #446

Closed

chore: release 2022-04-29 #456

Closed

chore: release 2022-04-29 #461

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(spec): better filters type #413

fix(spec): better filters type #413

shortcuts commented Apr 21, 2022 •

edited

Loading

netlify bot commented Apr 21, 2022 •

edited

Loading

algolia-bot commented Apr 21, 2022 •

edited

Loading

shortcuts Apr 22, 2022

millotp left a comment

millotp Apr 25, 2022

shortcuts Apr 25, 2022

millotp Apr 26, 2022

shortcuts Apr 26, 2022

shortcuts Apr 26, 2022

millotp Apr 26, 2022

shortcuts Apr 26, 2022

shortcuts Apr 26, 2022

millotp Apr 26, 2022

shortcuts Apr 26, 2022

shortcuts Apr 26, 2022

damcou Apr 26, 2022

shortcuts Apr 26, 2022

millotp left a comment

shortcuts commented Apr 26, 2022

millotp commented Apr 26, 2022

shortcuts commented Apr 26, 2022

fix(spec): better filters type #413

fix(spec): better filters type #413

Conversation

shortcuts commented Apr 21, 2022 • edited Loading

🧭 What and Why

Changes included:

🧪 Test

netlify bot commented Apr 21, 2022 • edited Loading

✅ Deploy Preview for api-clients-automation ready!

algolia-bot commented Apr 21, 2022 • edited Loading

✗ The generated branch has been deleted.

Choose a reason for hiding this comment

millotp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

millotp left a comment

Choose a reason for hiding this comment

shortcuts commented Apr 26, 2022

millotp commented Apr 26, 2022

shortcuts commented Apr 26, 2022

shortcuts commented Apr 21, 2022 •

edited

Loading

netlify bot commented Apr 21, 2022 •

edited

Loading

algolia-bot commented Apr 21, 2022 •

edited

Loading