Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python version in tests #88

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Update python version in tests #88

merged 5 commits into from
Jun 19, 2024

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented Jun 19, 2024

This PR updates python to 3.11 for the tests, in order to align the deps with idyntree 12.3.2.
Fixes #87

@Giulero
Copy link
Collaborator Author

Giulero commented Jun 19, 2024

@Giulero Giulero requested a review from traversaro June 19, 2024 09:58
@@ -23,6 +23,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
sudo apt install build-essential
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who needs build-essential ? If some dependency is not available as wheel, we are in deep trouble anyhow.

Copy link
Collaborator Author

@Giulero Giulero Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed a leftover. We were trying to fix the fail with this with @GiulioRomualdi. Removing!

@Giulero
Copy link
Collaborator Author

Giulero commented Jun 19, 2024

Thanks a lot!

@Giulero Giulero merged commit b2bcb14 into main Jun 19, 2024
15 checks passed
@Giulero Giulero deleted the Giulero-patch-1 branch June 19, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing tests - Failed to build idyntree
2 participants