Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch specifics to Contributing guide #360

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

Tompage1994
Copy link
Contributor

What does this PR do?

Adds mentions of the correct branch to start from and merge to in Contributing.md

How should this be tested?

N/A Doc change

Is there a relevant Issue open for this?

resolves #356

Other Relevant info, PRs, etc

N/A

Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit aba612d into ansible:devel Feb 9, 2024
8 of 13 checks passed
sean-m-sullivan added a commit that referenced this pull request Feb 27, 2024
* Update pre-commit (#326)

Co-authored-by: branic <branic@users.noreply.github.com>

* Update pre-commit

* Fix ansible-lint running against .py files (#332)

* Fix ansible-lint running against .py files

* Fix a pylint issue

* Update description in the user role README (#333)

Updated the one line description in the role.

Co-authored-by: Sean Sullivan <ssulliva@redhat.com>

* Fix version comparison (#337)

fix #334

alternative implementarion for #335

* Update pre-commit (#338)

Co-authored-by: branic <branic@users.noreply.github.com>

* user: Fix password type field in README (#342)

The `password` type was set to bool instead of str.

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>

* update repository roles (#343)

Co-authored-by: David Danielsson <djdanielsson@users.noreply.github.com>

* Update pre-commit (#344)

Co-authored-by: branic <branic@users.noreply.github.com>

* Fix wording to sync (#345)

* Update pre-commit

* Fix markdown tables (#349)

Co-authored-by: Sean Sullivan <ssulliva@redhat.com>

* Update pre-commit (#348)

Co-authored-by: branic <branic@users.noreply.github.com>
Co-authored-by: Sean Sullivan <ssulliva@redhat.com>

* Update pre-commit

* collection_remote: set sync_dependencies default to PAH default (#346)

Co-authored-by: David Danielsson <djdanielsson@users.noreply.github.com>

* Fix typo in ah_group_roles variable

* Add branch specifics to Contributing guide (#360)

* Fix documentation for validate_certs (#364)

* Fixed issue in all roles where AH_HOST was not being defaulted to if no variable set (#363)

* Fix documentation for group_roles role (#359)

* Update pre-commit (#361)

Co-authored-by: branic <branic@users.noreply.github.com>

---------

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: branic <branic@users.noreply.github.com>
Co-authored-by: Tom Page <tpage@redhat.com>
Co-authored-by: Richard J Osborne <20555769+rjo-uk@users.noreply.github.com>
Co-authored-by: Bruno Rocha <rochacbruno@users.noreply.github.com>
Co-authored-by: Dimitri Savineau <savineau.dimitri@gmail.com>
Co-authored-by: David Danielsson <djdanielsson@users.noreply.github.com>
Co-authored-by: dbk-rabel <57803476+dbk-rabel@users.noreply.github.com>
Co-authored-by: Bram Mertens <bmertens@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing.md should specify which branch to base a PR on
2 participants